Patch regression from change to to-relative-to-object

boa-dev · Jul 9, 2024 · 878ebd3 · 878ebd3
1 parent 5889a76
commit 878ebd3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/core/engine/src/builtins/temporal/mod.rs b/core/engine/src/builtins/temporal/mod.rs
@@ -252,6 +252,7 @@ pub(crate) fn to_relative_temporal_object(
     let plain_date = match relative_to {
         JsValue::String(relative_to_str) => JsValue::from(relative_to_str),
         JsValue::Object(relative_to_obj) => JsValue::from(relative_to_obj),
+        JsValue::Undefined => return Ok((None, None)),
         _ => {
             return Err(JsNativeError::typ()
                 .with_message("Invalid type for converting to relativeTo object")

diff --git a/core/engine/src/builtins/temporal/options.rs b/core/engine/src/builtins/temporal/options.rs
@@ -53,12 +53,12 @@ pub(crate) fn get_difference_settings(
     context: &mut Context,
 ) -> JsResult<DifferenceSettings> {
     let mut settings = DifferenceSettings::default();
-    settings.rounding_mode =
-        get_option::<TemporalRoundingMode>(options, js_str!("roundingMode"), context)?;
+    settings.largest_unit = get_option::<TemporalUnit>(options, js_str!("largestUnit"), context)?;
     settings.increment =
         get_option::<RoundingIncrement>(options, js_str!("roundingIncrement"), context)?;
+    settings.rounding_mode =
+        get_option::<TemporalRoundingMode>(options, js_str!("roundingMode"), context)?;
     settings.smallest_unit = get_option::<TemporalUnit>(options, js_str!("smallestUnit"), context)?;
-    settings.largest_unit = get_option::<TemporalUnit>(options, js_str!("largestUnit"), context)?;
     Ok(settings)
 }