Apply review pt.2

boa_engine/src/lib.rs

@@ -35,7 +35,6 @@
     clippy::needless_pass_by_value,
     clippy::match_wildcard_for_single_variants,
     clippy::map_unwrap_or,
-    clippy::missing_inline_in_public_items,
     unused_qualifications,
     unused_import_braces,
     unused_lifetimes,
@@ -53,6 +52,7 @@
     nonstandard_style,
 )]
 #![allow(
+    clippy::missing_inline_in_public_items,
     clippy::module_name_repetitions,
     clippy::cast_possible_truncation,
     clippy::cast_sign_loss,

boa_engine/src/syntax/ast/expression/access.rs

@@ -25,12 +25,14 @@ impl PropertyAccessField {
 }
 
 impl From<Sym> for PropertyAccessField {
+    #[inline]
     fn from(id: Sym) -> Self {
         Self::Const(id)
     }
 }
 
 impl From<Expression> for PropertyAccessField {
+    #[inline]
     fn from(expr: Expression) -> Self {
         Self::Expr(Box::new(expr))
     }
@@ -66,15 +68,18 @@ pub struct PropertyAccess {
 }
 
 impl PropertyAccess {
+    #[inline]
     pub fn target(&self) -> &Expression {
         &self.target
     }
 
+    #[inline]
     pub fn field(&self) -> &PropertyAccessField {
         &self.field
     }
 
     /// Creates a `PropertyAccess` AST Expression.
+    #[inline]
     pub fn new<F>(target: Expression, field: F) -> Self
     where
         F: Into<PropertyAccessField>,
@@ -97,6 +102,7 @@ impl PropertyAccess {
 }
 
 impl ToInternedString for PropertyAccess {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         let target = self.target.to_interned_string(interner);
         match self.field {
@@ -109,6 +115,7 @@ impl ToInternedString for PropertyAccess {
 }
 
 impl From<PropertyAccess> for Expression {
+    #[inline]
     fn from(access: PropertyAccess) -> Self {
         Self::PropertyAccess(access)
     }
@@ -166,6 +173,7 @@ impl PrivatePropertyAccess {
 }
 
 impl ToInternedString for PrivatePropertyAccess {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         format!(
             "{}.#{}",
@@ -176,6 +184,7 @@ impl ToInternedString for PrivatePropertyAccess {
 }
 
 impl From<PrivatePropertyAccess> for Expression {
+    #[inline]
     fn from(access: PrivatePropertyAccess) -> Self {
         Self::PrivatePropertyAccess(access)
     }
@@ -201,6 +210,7 @@ impl SuperPropertyAccess {
     }
 
     /// Gets the name of the field to retrieve.
+    #[inline]
     pub fn field(&self) -> &PropertyAccessField {
         &self.field
     }
@@ -217,6 +227,7 @@ impl SuperPropertyAccess {
 }
 
 impl ToInternedString for SuperPropertyAccess {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         match &self.field {
             PropertyAccessField::Const(field) => {
@@ -230,6 +241,7 @@ impl ToInternedString for SuperPropertyAccess {
 }
 
 impl From<SuperPropertyAccess> for Expression {
+    #[inline]
     fn from(access: SuperPropertyAccess) -> Self {
         Self::SuperPropertyAccess(access)
     }

boa_engine/src/syntax/ast/expression/await.rs

@@ -42,18 +42,21 @@ impl<T> From<T> for Await
 where
     T: Into<Box<Expression>>,
 {
+    #[inline]
     fn from(e: T) -> Self {
         Self { expr: e.into() }
     }
 }
 
 impl ToInternedString for Await {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         format!("await {}", self.expr.to_indented_string(interner, 0))
     }
 }
 
 impl From<Await> for Expression {
+    #[inline]
     fn from(awaitexpr: Await) -> Self {
         Self::Await(awaitexpr)
     }

boa_engine/src/syntax/ast/expression/call.rs

@@ -58,6 +58,7 @@ impl Call {
 }
 
 impl ToInternedString for Call {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         format!(
             "{}({})",
@@ -68,6 +69,7 @@ impl ToInternedString for Call {
 }
 
 impl From<Call> for Expression {
+    #[inline]
     fn from(call: Call) -> Self {
         Self::Call(call)
     }
@@ -113,12 +115,14 @@ impl SuperCall {
 }
 
 impl ToInternedString for SuperCall {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         format!("super({})", join_nodes(interner, &self.args))
     }
 }
 
 impl From<SuperCall> for Expression {
+    #[inline]
     fn from(call: SuperCall) -> Self {
         Self::SuperCall(call)
     }

boa_engine/src/syntax/ast/expression/identifier.rs

@@ -30,24 +30,28 @@ pub struct Identifier {
 }
 
 impl PartialEq<Sym> for Identifier {
+    #[inline]
     fn eq(&self, other: &Sym) -> bool {
         self.ident == *other
     }
 }
 
 impl PartialEq<Identifier> for Sym {
+    #[inline]
     fn eq(&self, other: &Identifier) -> bool {
         *self == other.ident
     }
 }
 
 impl Identifier {
     /// Creates a new identifier AST Expression.
+    #[inline]
     pub fn new(ident: Sym) -> Self {
         Self { ident }
     }
 
     /// Retrieves the identifier's string symbol in the interner.
+    #[inline]
     pub fn sym(self) -> Sym {
         self.ident
     }
@@ -72,18 +76,21 @@ impl Identifier {
 }
 
 impl ToInternedString for Identifier {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         interner.resolve_expect(self.ident).to_owned()
     }
 }
 
 impl From<Sym> for Identifier {
+    #[inline]
     fn from(sym: Sym) -> Self {
         Self { ident: sym }
     }
 }
 
 impl From<Identifier> for Expression {
+    #[inline]
     fn from(local: Identifier) -> Self {
         Self::Identifier(local)
     }

boa_engine/src/syntax/ast/expression/literal/array.rs

@@ -59,6 +59,7 @@ impl ArrayLiteral {
 }
 
 impl AsRef<[Option<Expression>]> for ArrayLiteral {
+    #[inline]
     fn as_ref(&self) -> &[Option<Expression>] {
         &self.arr
     }
@@ -68,6 +69,7 @@ impl<T> From<T> for ArrayLiteral
 where
     T: Into<Box<[Option<Expression>]>>,
 {
+    #[inline]
     fn from(decl: T) -> Self {
         Self {
             arr: decl.into(),
@@ -77,6 +79,7 @@ where
 }
 
 impl ToInternedString for ArrayLiteral {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         let mut buf = String::from("[");
         let mut first = true;
@@ -96,6 +99,7 @@ impl ToInternedString for ArrayLiteral {
 }
 
 impl From<ArrayLiteral> for Expression {
+    #[inline]
     fn from(arr: ArrayLiteral) -> Self {
         Self::ArrayLiteral(arr)
     }

boa_engine/src/syntax/ast/expression/literal/mod.rs

@@ -120,48 +120,56 @@ pub enum Literal {
 }
 
 impl From<Sym> for Literal {
+    #[inline]
     fn from(string: Sym) -> Self {
         Self::String(string)
     }
 }
 
 impl From<f64> for Literal {
+    #[inline]
     fn from(num: f64) -> Self {
         Self::Num(num)
     }
 }
 
 impl From<i32> for Literal {
+    #[inline]
     fn from(i: i32) -> Self {
         Self::Int(i)
     }
 }
 
 impl From<BigInt> for Literal {
+    #[inline]
     fn from(i: BigInt) -> Self {
         Self::BigInt(Box::new(i))
     }
 }
 
 impl From<Box<BigInt>> for Literal {
+    #[inline]
     fn from(i: Box<BigInt>) -> Self {
         Self::BigInt(i)
     }
 }
 
 impl From<bool> for Literal {
+    #[inline]
     fn from(b: bool) -> Self {
         Self::Bool(b)
     }
 }
 
 impl From<Literal> for Expression {
+    #[inline]
     fn from(lit: Literal) -> Self {
         Expression::Literal(lit)
     }
 }
 
 impl ToInternedString for Literal {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         match *self {
             Self::String(st) => {

boa_engine/src/syntax/ast/expression/literal/object/mod.rs

@@ -39,6 +39,7 @@ pub struct ObjectLiteral {
 }
 
 impl ObjectLiteral {
+    #[inline]
     pub fn properties(&self) -> &[PropertyDefinition] {
         &self.properties
     }
@@ -133,6 +134,7 @@ impl ObjectLiteral {
 }
 
 impl ToInternedString for ObjectLiteral {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         self.to_indented_string(interner, 0)
     }
@@ -142,6 +144,7 @@ impl<T> From<T> for ObjectLiteral
 where
     T: Into<Box<[PropertyDefinition]>>,
 {
+    #[inline]
     fn from(props: T) -> Self {
         Self {
             properties: props.into(),
@@ -150,6 +153,7 @@ where
 }
 
 impl From<ObjectLiteral> for Expression {
+    #[inline]
     fn from(obj: ObjectLiteral) -> Self {
         Self::ObjectLiteral(obj)
     }

boa_engine/src/syntax/ast/expression/literal/template.rs

@@ -19,6 +19,7 @@ pub struct TemplateLiteral {
 }
 
 impl From<TemplateLiteral> for Expression {
+    #[inline]
     fn from(tem: TemplateLiteral) -> Self {
         Self::TemplateLiteral(tem)
     }
@@ -32,6 +33,7 @@ pub enum TemplateElement {
 }
 
 impl TemplateLiteral {
+    #[inline]
     pub fn new(elements: Box<[TemplateElement]>) -> Self {
         Self { elements }
     }
@@ -58,6 +60,7 @@ impl TemplateLiteral {
 }
 
 impl ToInternedString for TemplateLiteral {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         let mut buf = "`".to_owned();
 

boa_engine/src/syntax/ast/expression/mod.rs

@@ -143,6 +143,7 @@ pub enum Expression {
 
 impl Expression {
     /// Creates a string of the value of the expression with the given indentation.
+    #[inline]
     pub fn to_indented_string(&self, interner: &Interner, indentation: usize) -> String {
         self.to_no_indent_string(interner, indentation)
     }
@@ -274,12 +275,14 @@ impl Expression {
 }
 
 impl From<Expression> for Statement {
+    #[inline]
     fn from(expr: Expression) -> Self {
         Statement::Expression(expr)
     }
 }
 
 impl ToInternedString for Expression {
+    #[inline]
     fn to_interned_string(&self, interner: &Interner) -> String {
         self.to_indented_string(interner, 0)
     }