Merge 9d3d578 into 2239669

boa-dev · Apr 8, 2022 · 5eeac73 · 5eeac73
2 parents 2239669 + 9d3d578
commit 5eeac73
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/boa_engine/src/builtins/array_buffer/mod.rs b/boa_engine/src/builtins/array_buffer/mod.rs
@@ -128,7 +128,7 @@ impl ArrayBuffer {
         Ok(args
             .get_or_undefined(0)
             .as_object()
-            .map(|obj| obj.borrow().is_typed_array())
+            .map(|obj| obj.borrow().has_viewed_array_buffer())
             .unwrap_or_default()
             .into())
     }

diff --git a/boa_engine/src/object/mod.rs b/boa_engine/src/object/mod.rs
@@ -519,6 +519,23 @@ impl Object {
         }
     }
 
+    #[inline]
+    pub(crate) fn has_viewed_array_buffer(&self) -> bool {
+        self.is_typed_array() || self.is_data_view()
+    }
+
+    /// Checks if it an `DataView` object.
+    #[inline]
+    pub fn is_data_view(&self) -> bool {
+        matches!(
+            self.data,
+            ObjectData {
+                kind: ObjectKind::DataView(_),
+                ..
+            }
+        )
+    }
+
     /// Checks if it an `ArrayBuffer` object.
     #[inline]
     pub fn is_array_buffer(&self) -> bool {