Add java code decompilation to unit tests #2
Conversation
LachlanMcKee
force-pushed
the
add-java-code-decompilation
branch
from
dc39bba to
345da00
Compare
| @@ -40,6 +47,9 @@ fun main() { | |||
|
|
|||
| @DebugLog | |||
| fun greet(greeting: String = "Hello", name: String = "World"): String { | |||
| if (greeting != "Hello") { | |||
There was a problem hiding this comment.
I thought it would be useful to see that the modified code also adds a println before an early return!
There was a problem hiding this comment.
I definitely like the idea of testing early return, but I would prefer to keep this particular source example really straight forward. Could early return (any even exception testing) be done as a different source file? I want the first thing people see in this file to be something really simple so maybe exit testing is a separate test class all together.
|
@bnorm hey! I am happy with this PR if you want to take a look. Happy to chat through it if there is anything you want change/elaborated |
| @@ -40,6 +47,9 @@ fun main() { | |||
|
|
|||
| @DebugLog | |||
| fun greet(greeting: String = "Hello", name: String = "World"): String { | |||
| if (greeting != "Hello") { | |||
There was a problem hiding this comment.
I definitely like the idea of testing early return, but I would prefer to keep this particular source example really straight forward. Could early return (any even exception testing) be done as a different source file? I want the first thing people see in this file to be something really simple so maybe exit testing is a separate test class all together.
debuglog-plugin/src/test/kotlin/com/bnorm/debug/log/IrPluginTest.kt
Outdated
Show resolved
Hide resolved
debuglog-plugin/src/test/kotlin/com/bnorm/debug/log/IrPluginTest.kt
Outdated
Show resolved
Hide resolved
debuglog-plugin/src/test/kotlin/com/bnorm/debug/log/IrPluginTest.kt
Outdated
Show resolved
Hide resolved
debuglog-plugin/src/test/kotlin/com/bnorm/debug/log/IrPluginTest.kt
Outdated
Show resolved
Hide resolved
| +irDebugExit(function, startTime, irGet(result)) | ||
| +expression.apply { | ||
| value = irGet(result) | ||
| if (expression.value.type == typeUnit) { |
There was a problem hiding this comment.
Without this change, I noticed that returning early in a function that does not have a return type (therefore Unit) would output "] = " + Unit.INSTANCE rather than "]"
LachlanMcKee
force-pushed
the
add-java-code-decompilation
branch
2 times, most recently
from
13c1866 to
2c9253a
Compare
LachlanMcKee
force-pushed
the
add-java-code-decompilation
branch
from
2c9253a to
a4b83a0
Compare
| import com.strobel.decompiler.PlainTextOutput | ||
| import com.tschuchort.compiletesting.KotlinCompilation | ||
| import com.tschuchort.compiletesting.SourceFile | ||
| import java.io.ByteArrayOutputStream |
There was a problem hiding this comment.
Weirdly ktlint was not passing until I moved the java imports above org. pinterest/ktlint#527
|
@bnorm I believe I have made the appropriate changes. Mind taking another look? |
This introduces Java Decompilation to the unit tests to make it clearer what the end result will be.
Happy to take any suggestions onboard.