Work around clang++ 15.0.7 compiler bug

Refs: nodejs/node#54576
bnoordhuis · Aug 27, 2024 · a8f58ab · a8f58ab
1 parent b305a1e
commit a8f58ab
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/libexec/extract-node b/libexec/extract-node
@@ -32,6 +32,7 @@ cd "${src}/node-v${version}"
 #patch -p1 < "${top}"/patch/gyp-libv8_monolith.patch
 #patch -p1 < "${top}"/patch/py2-icutrim.patch
 #patch -p1 < "${top}"/patch/py2-genv8constants.patch
+patch -p1 < "${top}"/patch/v8-no-assert-trivially-copyable.patch
 patch -p1 < "${top}"/patch/v8-disable-madv-dontfork.patch
 patch -p1 < "${top}"/patch/v8-disable-pkey.patch
 

diff --git a/patch/v8-no-assert-trivially-copyable.patch b/patch/v8-no-assert-trivially-copyable.patch
@@ -0,0 +1,14 @@
+diff --git a/deps/v8/src/base/small-vector.h b/deps/v8/src/base/small-vector.h
+index edaab3a7a6..533a536178 100644
+--- a/deps/v8/src/base/small-vector.h
++++ b/deps/v8/src/base/small-vector.h
+@@ -20,9 +20,6 @@ namespace base {
+ // dynamic storage when it overflows.
+ template <typename T, size_t kSize, typename Allocator = std::allocator<T>>
+ class SmallVector {
+-  // Currently only support trivially copyable and trivially destructible data
+-  // types, as it uses memcpy to copy elements and never calls destructors.
+-  ASSERT_TRIVIALLY_COPYABLE(T);
+   static_assert(std::is_trivially_destructible<T>::value);
+
+  public: