Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src: fix spawnSync CHECK when SIGKILL fails
We might not have sufficient privileges to signal the child process so don't make assumptions about the return value of `uv_process_kill()`. Example: node -e 'child_process.spawnSync("sudo", ["ls"], { maxBuffer: 1 })' No test because: 1. The test needs to run as root (can't invoke sudo), and 2. The parent needs to drop privileges but can't, because then the child process won't have sufficient privileges. Fixes: nodejs#31747
- Loading branch information