-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AAAA records #9
base: master
Are you sure you want to change the base?
Conversation
Adjust bash script Remove unnecessary files
thanks for the contribution @GM-Alex, you beat me to it :) it's going to take a few days for me to find the time to merge and test. If you had an opportunity to rebase and resubmit, it would be much appreciated. Can I add you to the CONTRIBUTORS.txt file? |
I don't get the rebase thing, did I miss some update and worked on an outdated version? Sure can you add me to the contributor. ;) |
Hey Alex, there we a pull request which came in before yours which I merged, which means that now your changes won't merge without some manual intervention. If you did happen to have an opportunity to pull and refactor I might suggest you split the work into multiple pulls to separate the concerns (move Dockerfile vs AAAA) Thanks again for the good work. I expect to find some time in the coming days. |
Conflicts: Dockerfile docker/build_docker.sh docker/run_docker.sh
Rebase done ;) |
Adjust supervisord config
Adjust docker dns config file loading
Add ip from custom network
I implement AAAA records in a simple way, but it works like charm. I also adjust the bash script for building and running the container to use the source files instead of the git repository and remove double files.