[m2e] Avoid runtime errors due to API changes between 1.x and 2.x

[timothyjward]

Several types in M2E have been updated to use Lists rather than arrays. We have to implement the extra interface methods (where needed) and use reflective calls to avoid linking to a method which may not exist. All of this code is ugly, and should be removed once we can use a base of M2E 2.x.

Signed-off-by: Tim Ward [email protected]

[timothyjward]

I believe that this fixes #5409

[timothyjward]

I believe that the two commits above make everything work again. It's pretty horrible, and I look forward to being able to remove these hacks once Bndtools 7.0.0 uses M2E v2.x as a base.

[stbischof]

thx @timothyjward

[timothyjward]

thx @timothyjward

I'm hoping that this means it works for you? You can build locally with ./gradlew p2 and then install from org.bndtools.p2/generated/p2/

[stbischof]

this means just thank you for taking it. and placing the method there where the error happened.

I will build it later and report

[bjhargrave]

Once this is verified and merged, I will cherry-pick the commits to next for 6.4.0.

[stbischof]

with 2022-9 I do not see bundles in the bndrun view.

but the error is not longer there

An internal error occurred during: "Updating Maven Project".
Receiver class bndtools.m2e.MavenDependenciesRepository does not define or inherit an implementation 
of the resolved method 'abstract void mavenProjectChanged(java.util.List, org.eclipse.core.runtime.IProgressMonitor)' 
of interface org.eclipse.m2e.core.project.IMavenProjectChangedListener.

[timothyjward]

with 2022-9 I do not see bundles in the bndrun view.

but the error is not longer there

An internal error occurred during: "Updating Maven Project".
Receiver class bndtools.m2e.MavenDependenciesRepository does not define or inherit an implementation 
of the resolved method 'abstract void mavenProjectChanged(java.util.List, org.eclipse.core.runtime.IProgressMonitor)' 
of interface org.eclipse.m2e.core.project.IMavenProjectChangedListener.

It sounds like an improvement then. I found another place that needed a repeat of an abstract method to satisfy the linker in c8ea019 - if that wasn't the commit you build then it may be worth trying. Otherwise I'm not sure how else to fix this.

[stbischof]

i build after c8ea019

[timothyjward]

I think that this is ready to merge. I can't guarantee that all the M2E integration is working, but it does appear substantially improved. I am able to build/resolve/run my test workspace in both old and new versions of Eclipse.

[stbischof]

jep this should be merged!
@timothyjward
old: 2022-03
new: 2022-06?