Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5336 Need -include loop detection #5391

Merged
merged 5 commits into from
Oct 7, 2022
Merged

#5336 Need -include loop detection #5391

merged 5 commits into from
Oct 7, 2022

Commits on Oct 6, 2022

  1. #5336 Need -include loop detection 

    The problem was that there was no test cases. There
actually was a loop detection. I already was incredibly
surprised because I am pretty sure I wrote this code
and forgetting to check cycles is even beneath me.However,
I'd forgotten to add a return after the error message ...

So the code continued forever to include the same
file anyway although dutifully reporting it.

Fixes #5336

Signed-off-by: Peter Kriens <[email protected]>
    @pkriens
    pkriens committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    b24bd83 View commit details
    Browse the repository at this point in the history

  2. ok, windows sucks as we know 

    ---
 Signed-off-by: Peter Kriens <[email protected]>

Signed-off-by: Peter Kriens <[email protected]>
    @pkriens
    pkriens committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    03abc45 View commit details
    Browse the repository at this point in the history

  3. oops 

    ---
 Signed-off-by: Peter Kriens <[email protected]>

Signed-off-by: Peter Kriens <[email protected]>
    @pkriens
    pkriens committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    1decc3f View commit details
    Browse the repository at this point in the history

  4. windows indeed is horrible 

    Signed-off-by: Peter Kriens <[email protected]>
    @pkriens
    pkriens committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    a2d67aa View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. something really weird. Tested it on windows and 

    worked fine

Signed-off-by: Peter Kriens <[email protected]>
    @pkriens
    pkriens committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    d342778 View commit details
    Browse the repository at this point in the history