Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify node start #91

Merged
merged 16 commits into from
Apr 25, 2024

Conversation

redhdx
Copy link
Contributor

@redhdx redhdx commented Apr 23, 2024

Description

Simplify op-geth start.

Rationale

Currently, starting op-geth requires manual setting of many parameters. In order to facilitate users to start nodes, some default configuration added for opBNB mainnet and testnet.

Example

Currently, there are two network configurations, opBNB mainnet and testnet by default. You can select the corresponding network configuration by setting --opBNBMainnet or --opBNBTestnet. You also need to set some config manually:

  • --authrpc.jwtsecret=./jwt.txt
  • --rollup.sequencerhttp=L2_RPC
  • --datadir=./datadir

You can start the node in the following way. If you are starting a new node, you do not need to init genesis.json. If you just restart the node and have already inited genesis.json, you can still use this command. You do not need to set --datadir. The op-geth will provide a default datadir. You can see the data path in the startup log. like this:

 database=/.../Ethereum/opBNBTestnet/geth/chaindata
database=/.../Ethereum/opBNBMainnet/geth/chaindata

However, if you have set datadir before and started node, you must still set it and keep it consistent. It is recommended to set datadir manually.

For example:

 ./geth --opBNBMainnet --authrpc.jwtsecret=./jwt.txt --datadir=./datadir --rollup.sequencerhttp=L2_RPC
 ./geth --opBNBTestnet --authrpc.jwtsecret=./jwt.txt --datadir=./datadir --rollup.sequencerhttp=L2_RPC

Changes

Notable changes:

  • add some default settings for opBNB

@github-actions github-actions bot requested review from krish-nr and welkin22 April 23, 2024 08:09
cmd/utils/flags.go Outdated Show resolved Hide resolved
miner/miner.go Outdated Show resolved Hide resolved
miner/miner.go Outdated Show resolved Hide resolved
@owen-reorg owen-reorg changed the title Feature/simplify node start feat: simplify node start Apr 24, 2024
owen-reorg
owen-reorg previously approved these changes Apr 24, 2024
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for one question

cmd/geth/main.go Outdated Show resolved Hide resolved
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit af39caa into bnb-chain:develop Apr 25, 2024
1 check passed
owen-reorg pushed a commit to owen-reorg/op-geth that referenced this pull request Apr 25, 2024
fork.yaml: update fork diff for v1.11.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants