-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify node start #91
Merged
owen-reorg
merged 16 commits into
bnb-chain:develop
from
redhdx:feature/simplify_node_start
Apr 25, 2024
Merged
feat: simplify node start #91
owen-reorg
merged 16 commits into
bnb-chain:develop
from
redhdx:feature/simplify_node_start
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
reviewed
Apr 24, 2024
owen-reorg
reviewed
Apr 24, 2024
owen-reorg
reviewed
Apr 24, 2024
owen-reorg
reviewed
Apr 24, 2024
owen-reorg
previously approved these changes
Apr 24, 2024
welkin22
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for one question
welkin22
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
owen-reorg
approved these changes
Apr 25, 2024
owen-reorg
pushed a commit
to owen-reorg/op-geth
that referenced
this pull request
Apr 25, 2024
fork.yaml: update fork diff for v1.11.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify op-geth start.
Rationale
Currently, starting op-geth requires manual setting of many parameters. In order to facilitate users to start nodes, some default configuration added for opBNB mainnet and testnet.
Example
Currently, there are two network configurations, opBNB mainnet and testnet by default. You can select the corresponding network configuration by setting
--opBNBMainnet
or--opBNBTestnet
. You also need to set some config manually:--authrpc.jwtsecret=./jwt.txt
--rollup.sequencerhttp=L2_RPC
--datadir=./datadir
You can start the node in the following way. If you are starting a new node, you do not need to init genesis.json. If you just restart the node and have already inited genesis.json, you can still use this command. You do not need to set
--datadir
. The op-geth will provide a default datadir. You can see the data path in the startup log. like this:However, if you have set datadir before and started node, you must still set it and keep it consistent. It is recommended to set datadir manually.
For example:
Changes
Notable changes:
opBNB