Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proof keeper #90

Merged
merged 18 commits into from
May 21, 2024
Merged

feat: add proof keeper #90

merged 18 commits into from
May 21, 2024

Conversation

will-2012
Copy link
Contributor

@will-2012 will-2012 commented Apr 23, 2024

Description

Add the proof keeper(only in path-base, bufferlist config) component to store the proposed proof in the background, and the op-proposal can query the proof in the proof keeper.

Rationale

nodebufferlist watch the block height and stores the proof of the corresponding block height according to the configuration.

Example

./op-geth \
  ...
  --state.scheme path \
  --pathdb.nodebuffer list \
  --pathdb.proposeblock 240 \
  --pathdb.enableproofkeeper \
  --pathdb.keepproofblockspan 100000 \ # This is optional, default is 90000.
  ...

This pathdb.enableproofkeeper enable proof keeper.

Changes

Notable changes:

  • core: add proof keeper skeleton.
  • rawdb: add keeper meta and proof data api.
  • pathdb: add watcher func in nodebufferlist.
  • API: adjust get proof API, can dispatch request to proof keeper.

@will-2012 will-2012 changed the title Feat keeper feat: add proof keeper Apr 23, 2024
@will-2012 will-2012 added the R4R Ready for review label Apr 23, 2024
cmd/utils/flags.go Outdated Show resolved Hide resolved
@will-2012 will-2012 marked this pull request as draft May 8, 2024 09:35
@will-2012 will-2012 added wip work in process and removed R4R Ready for review labels May 8, 2024
@will-2012 will-2012 force-pushed the feat-keeper branch 4 times, most recently from b17d716 to 614ff75 Compare May 8, 2024 12:58
@will-2012 will-2012 added R4R Ready for review and removed wip work in process labels May 8, 2024
@will-2012 will-2012 marked this pull request as ready for review May 8, 2024 15:32
@github-actions github-actions bot requested a review from redhdx May 8, 2024 15:32
krish-nr
krish-nr previously approved these changes May 14, 2024
Copy link
Contributor

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sysvm
sysvm previously approved these changes May 14, 2024
@will-2012 will-2012 dismissed stale reviews from krish-nr and sysvm via 098298b May 17, 2024 01:38
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@redhdx redhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit e916a8a into bnb-chain:develop May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R4R Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants