feat(txpool): improve performance of Reheap #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
pushed a commit
to owen-reorg/op-geth
that referenced
this pull request
Apr 25, 2024
…ith-time Update goerli regolith hardfork time
owen-reorg
approved these changes
May 28, 2024
owen-reorg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reheap() needs to be finished as quickly as possible to support a high-throughput pool.
Rationale
By profiling the CPU usages, we find that the GasTipCap() and GasFeeCap() cost the most, so we rewrite the compare function to avoid the non-sense calling of new(big.Int) and big.Set.