Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add miner perf metrics #71

Merged
merged 9 commits into from
Apr 8, 2024
Merged

chore: add miner perf metrics #71

merged 9 commits into from
Apr 8, 2024

Conversation

bnoieh
Copy link
Contributor

@bnoieh bnoieh commented Mar 13, 2024

Description

add miner perf metrics

Rationale

to help analysis miner performance

Example

n/a

Changes

  1. add some miner perf metrics
  2. change value of metric blockExecutionTimer and blockValidationTimer

@github-actions github-actions bot requested review from krish-nr and welkin22 March 13, 2024 10:30
@welkin22
Copy link
Contributor

LGTM, but maybe we should fix the unit test CI. If there are cases from upstream that cannot pass, we can ignore them for now. You can use t.SkipNow() to skip in the code.

welkin22
welkin22 reviewed Mar 21, 2024
View reviewed changes
core/blockchain.go Outdated Show resolved Hide resolved
@bnoieh
Copy link
Contributor Author

bnoieh commented Mar 27, 2024

LGTM, but maybe we should fix the unit test CI. If there are cases from upstream that cannot pass, we can ignore them for now. You can use t.SkipNow() to skip in the code.

will use another pr to fix that

welkin22
welkin22 previously approved these changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

krish-nr
krish-nr previously approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

owen-reorg
owen-reorg reviewed Apr 8, 2024
View reviewed changes
ethdb/pebble/pebble.go Outdated Show resolved Hide resolved
@bnoieh bnoieh dismissed stale reviews from krish-nr and welkin22 via 0a003b7 April 8, 2024 03:26
welkin22
welkin22 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit c5a0092 into bnb-chain:develop Apr 8, 2024
1 check passed
@owen-reorg owen-reorg mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welkin22 welkin22 welkin22 approved these changes

@krish-nr krish-nr krish-nr approved these changes

@owen-reorg owen-reorg owen-reorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnoieh @welkin22 @owen-reorg @krish-nr @nolanxyg