Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-geth):fix static peer cannot reassign header tasks #64

Merged
merged 8 commits into from
Feb 22, 2024

Conversation

krish-nr
Copy link
Contributor

@krish-nr krish-nr commented Feb 21, 2024

Description

disconnect and reconnect peer when a header gap occurs

Rationale

when ignore header anchor, static peers cannot reassign header tasks with the same connection, reconnect need to be processed to get reassigned header link task

Example

N/A

Changes

Notable changes:

  • disconnect and reconnect peer when a header gap error occurs

Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bendanzhentan bendanzhentan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with the author.
The main problem here is that the errorous connection can't be reassigned header tasks. This PR serves as a temporary solution.

@krish-nr krish-nr merged commit 993383b into bnb-chain:develop Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants