feat: Drop non-local transactions whose gas fee cap is below or equal to the potential minimum base fee #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the potential minimum base fee
owen-reorg
requested review from
bnoieh and
andyzhang2023
and removed request for
welkin22 and
redhdx
bnoieh
approved these changes
Nov 30, 2023
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 15, 2024
…ion; (bnb-chain#35) * mvstates: fix async dep gen deadlock issue; miner: support record sysytem tx rwset; * miner: opt txdag enable checking; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Sep 25, 2024
…ion; (bnb-chain#35) * mvstates: fix async dep gen deadlock issue; miner: support record sysytem tx rwset; * miner: opt txdag enable checking; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Oct 11, 2024
…ion; (bnb-chain#35) * mvstates: fix async dep gen deadlock issue; miner: support record sysytem tx rwset; * miner: opt txdag enable checking; --------- Co-authored-by: galaio <[email protected]>
welkin22
pushed a commit
that referenced
this pull request
Oct 22, 2024
…ion; (#35) * mvstates: fix async dep gen deadlock issue; miner: support record sysytem tx rwset; * miner: opt txdag enable checking; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Nov 14, 2024
…ion; (bnb-chain#35) * mvstates: fix async dep gen deadlock issue; miner: support record sysytem tx rwset; * miner: opt txdag enable checking; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Dec 11, 2024
…ion; (bnb-chain#35) * mvstates: fix async dep gen deadlock issue; miner: support record sysytem tx rwset; * miner: opt txdag enable checking; --------- Co-authored-by: galaio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drop non-local transactions whose gas fee cap is below or equal to the potential minimum base fee
Rationale
Currently, there are transactions with a gas fee cap lower than 8 wei (the potential minimum base fee according to the current EIP1559 configuration). These transactions will never be included in a block. As a result, they remain in the transaction pool until it is full and they are kicked out by transactions with a higher gas price.
This pull request aims to prevent such transactions from entering the transaction pool.
Example
NA
Changes
Notable changes: