feat: add option to reannounce remote transactions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyzhang2023
changed the title
owen-reorg
approved these changes
Nov 23, 2023
owen-reorg
changed the title
|
Is re-announce on local transactions enabled by default? Can it be set? |
redhdx
approved these changes
Nov 24, 2023
yes, check this: #2 |
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 14, 2024
* txdag: fix system tx finalise issue; * txdag: fix system tx finalise issue; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Sep 25, 2024
* txdag: fix system tx finalise issue; * txdag: fix system tx finalise issue; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Oct 11, 2024
* txdag: fix system tx finalise issue; * txdag: fix system tx finalise issue; --------- Co-authored-by: galaio <[email protected]>
welkin22
pushed a commit
that referenced
this pull request
Oct 22, 2024
* txdag: fix system tx finalise issue; * txdag: fix system tx finalise issue; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Nov 14, 2024
* txdag: fix system tx finalise issue; * txdag: fix system tx finalise issue; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Dec 11, 2024
* txdag: fix system tx finalise issue; * txdag: fix system tx finalise issue; --------- Co-authored-by: galaio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new feature allow us to re-announce on remote transactions, but not only local transactions.
Rationale
The re-announce only applied on local transaction so far, but in some special network architectures, transactions need to be passed to miner via P2P network, which means the re-announce don't work on them. That's the reason why we add this option.
Example
Its default value is false.
Changes
Notable changes: