Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-geth): fix gasless receipt l1fee #219

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

redhdx
Copy link
Contributor

@redhdx redhdx commented Nov 11, 2024

Description

Fix gasless tx receipt l1 fee result.

Rationale

When TipFeeCap is 0 and GasFeeCap is not, the effective gas price is 0, opBNB not charge L1 fee, but the result of tx receipt
shows that l1fee is charged.

Example

https://testnet.opbnbscan.com/tx/0xf54b5aa2960baaed2d426c97f947ce79e39fd575047f55d2de9d8f8732833a63

Changes

Notable changes:

  • Fix gasless tx receipt l1 fee result, when effective gas price is 0, the l1 fee is 0.

core/types/receipt.go Outdated Show resolved Hide resolved
owen-reorg
owen-reorg previously approved these changes Nov 12, 2024
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit 1770748 into bnb-chain:develop Nov 12, 2024
1 check passed
bnoieh pushed a commit to bnoieh/op-geth that referenced this pull request Nov 29, 2024
…eescalar

ethapi: handle fee-scalar receipt attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants