fix: refraining from using gopool for long-running tasks[BNB-19] #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkin22
changed the title
bendanzhentan
approved these changes
Oct 19, 2023
owen-reorg
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
goto run long-running tasks instead of gopoolRationale
The gopool limits the go-routines to run at a time, keeping the total go-routine memory in a manageable state.
However, for a long-running task, it will occupy a worker from the pool and never return, causing the effective pool size to decrease.
Example
none
Changes
Notable changes:
goto run long-running tasks instead of gopool