-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle error[BNB-16] #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
approved these changes
Nov 23, 2023
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 2, 2024
* txdag: opt some logic; txdag: opt rw set collect logic; * pevm: opt logs; * txdag: opt txdag encoding, reduce rlp size; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 7, 2024
* txdag: opt some logic; txdag: opt rw set collect logic; * pevm: opt logs; * txdag: opt txdag encoding, reduce rlp size; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 13, 2024
* txdag: opt some logic; txdag: opt rw set collect logic; * pevm: opt logs; * txdag: opt txdag encoding, reduce rlp size; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Sep 25, 2024
* txdag: opt some logic; txdag: opt rw set collect logic; * pevm: opt logs; * txdag: opt txdag encoding, reduce rlp size; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Oct 11, 2024
* txdag: opt some logic; txdag: opt rw set collect logic; * pevm: opt logs; * txdag: opt txdag encoding, reduce rlp size; --------- Co-authored-by: galaio <[email protected]>
welkin22
pushed a commit
that referenced
this pull request
Oct 22, 2024
* txdag: opt some logic; txdag: opt rw set collect logic; * pevm: opt logs; * txdag: opt txdag encoding, reduce rlp size; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Nov 14, 2024
* txdag: opt some logic; txdag: opt rw set collect logic; * pevm: opt logs; * txdag: opt txdag encoding, reduce rlp size; --------- Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Dec 11, 2024
* txdag: opt some logic; txdag: opt rw set collect logic; * pevm: opt logs; * txdag: opt txdag encoding, reduce rlp size; --------- Co-authored-by: galaio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
core/state_prefetcher.go:Prefetch()
function, the error of theprecacheTransaction()
call is not handled.gopool/pool.go:Submit()
function returns an error, but none of the callers handle it. Based on our analysis, since thedefaultPool is not created with the Nonblocking flag, the underlying call
defaultPool.Submit()
does not expect an error. In this case, it is recommended to consider changing the function signature ofpool.go:Submit()
to not return an error and instead log an error message within the function.core/blockchain.go:writeBlockWithState()#L1440
, the error is not handled in the call ofbc.triedb.Commit()
.core/blockchain.go:writeBlockWithState()#L1421
function, the error is not handled in the call ofbc.triedb.Cap()
.Rationale
There are several places not handling returning error.
Example
none
Changes
Notable changes:
precacheTransaction()
call