fix: bubbling up the error when DeriveField() fails[BNB-13] #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendanzhentan
approved these changes
Oct 20, 2023
owen-reorg
approved these changes
Jan 5, 2024
owen-reorg
added a commit
that referenced
this pull request
Jan 5, 2024
This reverts commit 1f69107.
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 2, 2024
Co-authored-by: Sunny <[email protected]>
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 7, 2024
Co-authored-by: Sunny <[email protected]>
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 13, 2024
Co-authored-by: Sunny <[email protected]>
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Sunny <[email protected]>
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Oct 11, 2024
Co-authored-by: Sunny <[email protected]>
welkin22
pushed a commit
that referenced
this pull request
Oct 22, 2024
Co-authored-by: Sunny <[email protected]>
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Nov 14, 2024
Co-authored-by: Sunny <[email protected]>
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Sunny <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bubbling up the error when DeriveField() fails.
Rationale
In
blockchain.go:insertChain(), thetypes.Receipts(receipts).DeriveField()call can potentially return an error. In the case that theDeiveField()fails, the receipts will not have the expected data attached to it. However, the code caches the block data (CacheBlock()) and the receipt data (CacheReceipts()) no matter whether theDeriveField()errors out or not in theinsertChain()function. Incomplete or invalid data can be cached and risk causing unexpected scenario.Example
none
Changes
Notable changes: