Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimization: enlarge p2p buffer size and add some metrics for performance monitor #171

Merged
merged 12 commits into from
Oct 10, 2024
Merged

optimization: enlarge p2p buffer size and add some metrics for performance monitor #171

merged 12 commits into from
Oct 10, 2024

Conversation

andyzhang2023
Copy link
Contributor

Description

The improvement includes:

  1. enlarge p2p buffer size to 90k.
  2. change the latency metric of txpool.Add() to "latency of adding a tx on average", to find out how many transactions we can add at most via txpool.Add().
  3. add gc metrics for golang GC monitor.
  4. other logs optimization.

@andyzhang2023 andyzhang2023 changed the base branch from main to develop September 11, 2024 02:49
bnoieh
bnoieh reviewed Sep 19, 2024
View reviewed changes
core/blockchain.go Outdated Show resolved Hide resolved
core/blockchain.go Outdated Show resolved Hide resolved
internal/debug/flags.go Outdated Show resolved Hide resolved
@bnoieh bnoieh mentioned this pull request Sep 19, 2024
Closed
@owen-reorg owen-reorg changed the title enlarge p2p buffer size and add some metrics for performance monitor optimization: enlarge p2p buffer size and add some metrics for performance monitor Oct 10, 2024
@owen-reorg owen-reorg merged commit b4b9750 into bnb-chain:develop Oct 10, 2024
1 check passed
owen-reorg added a commit that referenced this pull request Oct 14, 2024
@andyzhang2023 @owen-reorg
optimization: enlarge p2p buffer size and add some metrics for perfor…
4b18fcd 
…mance monitor (#171)

Co-authored-by: Owen <[email protected]>
Co-authored-by: andyzhang2023 <[email protected]>
This was referenced Oct 14, 2024
Merged
Merged
welkin22 added a commit to welkin22/op-geth that referenced this pull request Oct 28, 2024
@welkin22
Revert "optimization: enlarge p2p buffer size and add some metrics fo…
fc9dc36 
…r performance monitor (bnb-chain#171)"

This reverts commit b4b9750.
bnoieh pushed a commit to bnoieh/op-geth that referenced this pull request Nov 29, 2024
@trianglesphere
Enable Canyon via superchain in op-geth (bnb-chain#171)
94fbbd0 
* Enable Canyon via the superchain registry

* Rename PostCanyon to Canyon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoieh bnoieh bnoieh approved these changes

@owen-reorg owen-reorg owen-reorg approved these changes

@krish-nr krish-nr Awaiting requested review from krish-nr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhang2023 @owen-reorg @bnoieh