fix: cache data after successful writing[BNB-12] #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkin22
changed the title
bnoieh
approved these changes
Oct 17, 2023
bendanzhentan
approved these changes
Oct 19, 2023
owen-reorg
approved these changes
Jan 5, 2024
andyzhang2023
pushed a commit
to andyzhang2023/op-geth
that referenced
this pull request
Jul 31, 2024
txdag: opt rw record flag; txdag: opt some logic; Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Jul 31, 2024
txdag: opt rw record flag; txdag: opt some logic; Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 7, 2024
txdag: opt rw record flag; txdag: opt some logic; Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Aug 13, 2024
txdag: opt rw record flag; txdag: opt some logic; Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Sep 25, 2024
txdag: opt rw record flag; txdag: opt some logic; Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Oct 11, 2024
txdag: opt rw record flag; txdag: opt some logic; Co-authored-by: galaio <[email protected]>
welkin22
pushed a commit
that referenced
this pull request
Oct 22, 2024
txdag: opt rw record flag; txdag: opt some logic; Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Nov 14, 2024
txdag: opt rw record flag; txdag: opt some logic; Co-authored-by: galaio <[email protected]>
sunny2022da
pushed a commit
to sunny2022da/op-geth
that referenced
this pull request
Dec 11, 2024
txdag: opt rw record flag; txdag: opt some logic; Co-authored-by: galaio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
blockchain.go, bothCacheBlock()andCacheReceipts()are called before the block is committed into the database in theinsertChain()function. In the event thatbc.writeBlockWithState()orbc.writeBlockAndSetHead()return an error, the block and receipt data might exist in the cache but not in the database.Rationale
Avoid writing to the cache when database writes fail to ensure data consistency
Example
none
Changes
CacheBlockandCacheReceiptscalls towriteBlockWithStateorwriteBlockAndSetHeadbehind