New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(op-geth): add opbnb gasless solution #130

Merged

owen-reorg merged 35 commits into bnb-chain:develop from redhdx:feature/opbnb_for_gasless

Aug 5, 2024

Contributor

redhdx commented Jul 18, 2024 •

edited

Loading

Description

Add opbnb gasless solution. This is a breaking change for opbnb. In order to enable opbnb to support gasless transactions, this PR introduces the new hard fork wright. After enabling the wright hard fork, opbnb's basefee will be 0. For transactions with a gasprice of 0, opbnb will not charge L1 cost. With this change, opbnb has added bundle transaction and bundle pool. Please refer bnb-chain/BEPs#322 to the specific implementation details.

Rationale

Add opbnb gasless solution which can enable opbnb to support gasless transaction.

Example

Changes

Notable changes:

add new hard fork wright.
add new apis about bundle.
- eth_bundlePrice: returns the price of a bundle
- eth_simulateGaslessBundle: simulates a gasless bundle
- eth_sendBundle: sends a bundle
add bundle pool.
building block add mev logic.
add new config.
- --mev.enable: enable mev feature, can enable bundle pool and receive bundle transactions
- --mev.bundle.receiver.url: enable bundle deliver function, can deliver bundle to the specific url.
- --mev.bundle.gasprice.floor: set bundle gas price floor, default value is 1.
- --bundlepool.globalslots: set bundle pool size, default value is 4096.


          feature(op-geth): add opbnb gasless solution

04d0f76

redhdx requested review from owen-reorg, bnoieh and welkin22

July 18, 2024 07:18

github-actions bot requested review from andyzhang2023 and krish-nr

July 18, 2024 07:18

redhdx added 3 commits

July 18, 2024 16:49


          fix(op-geth): fix ut for cycle import

711fee4


          Revert "fix(op-geth): fix ut for cycle import"

5d1162c

This reverts commit 711fee4.


          fix(op-geth): fix test for cycle import

0b3189e

welkin22 reviewed

View reviewed changes

core/txpool/bundlepool/bundlepool.go Outdated Show resolved Hide resolved


          feature(op-geth): add some config

ed4e69b

welkin22 reviewed

View reviewed changes

core/txpool/bundlepool/bundlepool.go Outdated Show resolved Hide resolved


          fix(op-geth): fix nil issue

d38ca5f

welkin22 reviewed

View reviewed changes

miner/worker_builder.go Outdated Show resolved Hide resolved

welkin22 reviewed

View reviewed changes

miner/worker_builder.go Outdated Show resolved Hide resolved


          fix(op-geth): fix test issue

600e647

welkin22 reviewed

View reviewed changes

core/txpool/bundlepool/bundlepool.go Outdated Show resolved Hide resolved

owen-reorg reviewed

View reviewed changes

cmd/utils/flags.go Outdated Show resolved Hide resolved

owen-reorg reviewed

View reviewed changes

cmd/utils/flags.go Outdated Show resolved Hide resolved

owen-reorg reviewed

View reviewed changes

cmd/utils/flags.go Show resolved Hide resolved

owen-reorg reviewed

View reviewed changes

core/txpool/bundlepool/config.go Outdated Show resolved Hide resolved

owen-reorg reviewed

View reviewed changes

core/txpool/bundlepool/config.go Outdated Show resolved Hide resolved

redhdx and others added 8 commits

July 24, 2024 09:45


          feature(op-geth): refine code

ba22582


          feature(op-geth): refine code mainly simplify config

ed8a579


          feature(op-geth): change qa net chain config

a4d0a85


          feature(op-geth): refine code

8b8e3b4


          Merge branch 'develop' into feature/opbnb_for_gasless

ec06717


          fix(op-geth): fix gasless l1 cost

12809f0


          fix(op-geth): fix gasless l1 cost

cbb1c03


          fix(op-geth): fix gasless l1 cost receipt

6f7deff

redhdx added 4 commits

July 30, 2024 16:47


          fix(op-geth): fix gaslimit issue

17986c9


          fix(op-geth): fix merge bundle logic

3642aee


          feature(op-geth): optimize bundle pool reset

f343264


          fix(op-geth): fix reset bundle

0d3f46b

owen-reorg reviewed

View reviewed changes

core/txpool/bundlepool/bundlepool.go Show resolved Hide resolved

redhdx added 6 commits

July 31, 2024 17:20


          fix(op-geth): fix some issue and change some const value

a249bc2


          fix(op-geth): fix ErrBundleGasPriceLow logic

a292ab1


          feature(op-geth): refine logic and fix issue

bfdf54a


          feature(op-geth): refine log print content

18b50d9


          fix(op-geth): fix time stop logic

0b6ea28


          fix(op-geth): fix issue

24e8c85

welkin22 mentioned this pull request

feat(op-chain-ops): add Wright fork config into genesis file generation code bnb-chain/opbnb#226

Merged

redhdx added 3 commits

August 1, 2024 18:48


          feature(op-geth): change BundleGasLimit

fdae74b


          feature(op-geth): change BundleGasLimit

c5d81ed


          feature(op-geth): change simulateGaslessBundle return logic

eb5c5ed

This was referenced Aug 2, 2024

feat: support Wright upgrade for opbnb bnb-chain/revm#52

Merged

feat: support Wright upgrade for opbnb bnb-chain/reth#94

Merged


          feature(op-geth): change simulateGaslessBundle return value

81a33bb

owen-reorg reviewed

View reviewed changes

miner/worker.go Show resolved Hide resolved

owen-reorg reviewed

View reviewed changes

miner/worker_builder.go Show resolved Hide resolved

welkin22 previously approved these changes

View reviewed changes

Contributor

welkin22 left a comment

LGTM

owen-reorg reviewed

View reviewed changes

miner/worker_builder.go Show resolved Hide resolved


          fix(op-geth): fix sort bundles

167d08f

redhdx dismissed welkin22’s stale review via

167d08f

August 5, 2024 09:12

Collaborator

owen-reorg commented Aug 5, 2024

plz add testnet fork time: 8.15 2pm utc+8


          feature(op-geth): add Wright hard fork time

6ccb086

owen-reorg approved these changes

View reviewed changes

welkin22 approved these changes

View reviewed changes

Contributor Author

redhdx commented Aug 5, 2024

plz add testnet fork time: 8.15 2pm utc+8

Added. Plz confirm it.

owen-reorg merged commit 7fd1790 into bnb-chain:develop

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

welkin22 welkin22 approved these changes

owen-reorg owen-reorg approved these changes

bnoieh Awaiting requested review from bnoieh

andyzhang2023 Awaiting requested review from andyzhang2023

krish-nr Awaiting requested review from krish-nr

Labels

None yet