Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recover node buffer list for pathdb #126

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

sysvm
Copy link
Contributor

@sysvm sysvm commented Jul 9, 2024

Description

Recover node buffer list for pathdb to avoid dropping many blocks in node buffer list. If using nodebufferlist and op-geth is force kill, it will recover nodebufferlist by default.

Rationale

The sequencer module of opBNB is used to generate blocks. At present, opBNB blocks out of a single node. If the force kill or OOM is performed on the sequencer module, a large number of blocks will be left, and the data stored in the nodecache will be lost. Therefore, this pr can be used to recover data on nodebufferlist.

Example

N/A

Changes

Notable changes:

  • N/A

@github-actions github-actions bot requested review from bnoieh and welkin22 July 9, 2024 12:09
@sysvm sysvm force-pushed the feat-difflayertool branch 7 times, most recently from 2123434 to 3ad50e4 Compare July 10, 2024 04:08
Copy link
Contributor

@will-2012 will-2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, this new difflayer redolog rebuild skeleton is ok.

trie/triedb/pathdb/database.go Outdated Show resolved Hide resolved
@sysvm sysvm force-pushed the feat-difflayertool branch 20 times, most recently from f824707 to 443e221 Compare July 11, 2024 03:59
@sysvm sysvm force-pushed the feat-difflayertool branch 2 times, most recently from 06fdd4c to 07f40d4 Compare August 13, 2024 02:53
@sysvm sysvm force-pushed the feat-difflayertool branch from 07f40d4 to ea2c9d4 Compare August 28, 2024 03:29
@sysvm sysvm force-pushed the feat-difflayertool branch 13 times, most recently from 179579b to 7d7eaa1 Compare September 9, 2024 07:06
@sysvm sysvm force-pushed the feat-difflayertool branch from 94a0c19 to 8e3263f Compare September 10, 2024 03:56
@sysvm sysvm force-pushed the feat-difflayertool branch from e7454bc to 3bf57a4 Compare September 20, 2024 02:37
Copy link
Contributor

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krish-nr krish-nr merged commit 5a039c4 into bnb-chain:develop Oct 16, 2024
1 check passed
@sysvm sysvm deleted the feat-difflayertool branch November 14, 2024 03:42
bnoieh pushed a commit to bnoieh/op-geth that referenced this pull request Nov 29, 2024
* Deploy create2deployer in the next hardfork

* Switch to superchain bytecode

* Also deploy to Base goerli

* Add comment, log, and test

* Add additional base testnets / devnets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R4R Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants