pathdb: handle persistent id when using nodebufferlist #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: will@2012 <[email protected]>
sysvm
changed the title
joeylichang
previously approved these changes
Jun 20, 2024
sysvm
force-pushed
the
nl_flush
branch
2 times, most recently
from
fa3e08b to
7bc4627
Compare
joeylichang
previously approved these changes
Jun 20, 2024
joeylichang
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using nodebufferlist in pathdb, geth should maintain three node cache in memory for withdrawal proof. This pr fixes a case that when the length of history is greater than
StateHistorybut not beyond maxBufferSize, nodebufferlist still should keep three node cache.Start a load test that uses 1000 accounts and 1TPS for about 50 hours to verify this pr, metrics are shown below:
Rationale
N/A
Example
N/A
Changes
Notable changes: