Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add opBNB V5 bootnodes #104

Merged

Conversation

redhdx
Copy link
Contributor

@redhdx redhdx commented May 6, 2024

Description

Add opBNB testnet and mainnet V5 bootnodes in code.

Rationale

Add opBNB testnet and mainnet V5 bootnodes in code can facilitate the startup of new nodes.

Example

The startup node will use the opBNB mainnet's V5 bootnodes by default. If the --opBNBTestnet is configured the testnet V5 bootnodes will be used. If the --networkid is configured and it is testnet, the testnet V5 bootnodes will be used. If --bootnodes is configured, the configured bootnodes will be used. The configured --bootnodes have the highest priority. The --networkid have the lowest priority.

Changes

Notable changes:

  • Add opBNB testnet and mainnet V5 bootnodes in code can facilitate the startup of new nodes.

@github-actions github-actions bot requested review from andyzhang2023 and welkin22 May 6, 2024 08:03
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andyzhang2023 andyzhang2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@welkin22 welkin22 merged commit 536ac5d into bnb-chain:merge/for_4844_merge May 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants