You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add precompiled contracts for light client validation
Rationale
The precompiled contracts for light client validation should not be removed here.
Example
NA
Changes
Notable changes:
NA
@keefel Hi, According to my understanding, Geth has removed the entire light client, as you can see the light option has been removed in gcMode. Please confirm this modification again.
If they are not the same thing, please provide further context and background knowledge to help us determine if the modification is feasible.
add precompiled contracts for light client validation
Rationale
The precompiled contracts for light client validation should not be removed here.
Example
NA
Changes
Notable changes:
NA
@keefel Hi, According to my understanding, Geth has removed the entire light client, as you can see the light option has been removed in gcMode. Please confirm this modification again. If they are not the same thing, please provide further context and background knowledge to help us determine if the modification is feasible.
The light client verification is utilized for Greenfield cross-chain communication, which differs from what you mentioned.
After communicating with my colleagues, I found the original PR: #7. Yes, we do need this modification in order to support Greenfield cross-chain. We overlooked this during the merge process. Thank you @keefel. Good catch!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add precompiled contracts for light client validation
Rationale
The precompiled contracts for light client validation should not be removed here.
Example
NA
Changes
Notable changes: