Skip to content

Commit

Permalink
add extra error info when meet a unexpected el sync
Browse files Browse the repository at this point in the history
  • Loading branch information
krish-nr committed Aug 1, 2024
1 parent 0c45fd0 commit e1be871
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
4 changes: 4 additions & 0 deletions eth/catalyst/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"errors"
"fmt"
"math/big"
"strings"
"sync"
"time"

Expand Down Expand Up @@ -681,6 +682,9 @@ func (api *ConsensusAPI) delayPayloadImport(block *types.Block) (engine.PayloadS
// that the parent state is missing and the syncer rejected extending the
// current cycle with the new payload.
log.Warn("Ignoring payload with missing parent", "number", block.NumberU64(), "hash", block.Hash(), "parent", block.ParentHash(), "reason", err)
if strings.Contains(err.Error(), "forced head needed for startup") {
return engine.PayloadStatusV1{Status: engine.SYNCING}, err
}
} else {
// In non-full sync mode (i.e. snap sync) all payloads are rejected until
// snap sync terminates as snap sync relies on direct database injections
Expand Down
12 changes: 7 additions & 5 deletions eth/catalyst/api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,15 @@ import (
"math/big"
"math/rand"
"reflect"
"strings"
"sync"
"testing"
"time"

"github.com/stretchr/testify/require"

"github.com/mattn/go-colorable"

"github.com/ethereum/go-ethereum/beacon/engine"
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/common/hexutil"
Expand All @@ -50,7 +53,6 @@ import (
"github.com/ethereum/go-ethereum/params"
"github.com/ethereum/go-ethereum/rpc"
"github.com/ethereum/go-ethereum/trie"
"github.com/mattn/go-colorable"
)

var (
Expand Down Expand Up @@ -717,7 +719,7 @@ func TestEmptyBlocks(t *testing.T) {
payload := getNewPayload(t, api, commonAncestor, nil)

status, err := api.NewPayloadV1(*payload)
if err != nil {
if err != nil && !strings.Contains(err.Error(), "forced head needed for startup") {
t.Fatal(err)
}
if status.Status != engine.VALID {
Expand All @@ -733,7 +735,7 @@ func TestEmptyBlocks(t *testing.T) {
payload = setBlockhash(payload)
// Now latestValidHash should be the common ancestor
status, err = api.NewPayloadV1(*payload)
if err != nil {
if err != nil && !strings.Contains(err.Error(), "forced head needed for startup") {
t.Fatal(err)
}
if status.Status != engine.INVALID {
Expand All @@ -751,7 +753,7 @@ func TestEmptyBlocks(t *testing.T) {
payload = setBlockhash(payload)
// Now latestValidHash should be the common ancestor
status, err = api.NewPayloadV1(*payload)
if err != nil {
if err != nil && !strings.Contains(err.Error(), "forced head needed for startup") {
t.Fatal(err)
}
if status.Status != engine.SYNCING {
Expand Down Expand Up @@ -863,7 +865,7 @@ func TestTrickRemoteBlockCache(t *testing.T) {
// feed the payloads to node B
for _, payload := range invalidChain {
status, err := apiB.NewPayloadV1(*payload)
if err != nil {
if err != nil && !strings.Contains(err.Error(), "forced head needed for startup") {
panic(err)
}
if status.Status == engine.VALID {
Expand Down

0 comments on commit e1be871

Please sign in to comment.