Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade cosmos sdk to v0.26.2 #942

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

forcodedancing
Copy link
Contributor

Description

This pr upgrades the cosmos sdk version to the latest one, to fix an issue in the cli client.

Rationale

Bug fix

Example

Before fix

/tbnbcli token info --symbol TCO-FC2 --chain-id=Binance-Chain-Ganges --node=data-seed-pre-0-s3.binance.org:80
ERROR: failed to prove merkle absence proof: Calculated root hash is invalid: expected [161 49 185 8 105 55 181 121 32 243 235 71 68 181 82 167 160 27 12 241 144 19 162 158 46 98 194 202 246 243 49 169] but got [39 141 219 74 147 43 56 167 105 71 172 202 68 173 171 108 109 124 101 138 17 151 247 201 119 103 250 236 190 16 28 228]

After fix

❯ ./tbnbcli token info --symbol BUSD-BAF --chain-id=Binance-Chain-Ganges --node=data-seed-pre-0-s3.binance.org:80
{
  "type": "bnbchain/Token",
  "value": {
    "name": "BUSD token",
    "symbol": "BUSD-BAF",
    "original_symbol": "BUSD",
    "total_supply": "16000000.00000000",
    "owner": "tbnb15yqj8s26vvf4l62954pr9wh8ltypwuzkmqwre4",
    "mintable": false,
    "contract_address": "0xeD24FC36d5Ee211Ea25A80239Fb8C4Cfd80f12Ee",
    "contract_decimals": 18
  }
}

Changes

Notable changes:

  • go.mod

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@forcodedancing forcodedancing changed the base branch from master to develop April 18, 2023 08:31
@forcodedancing forcodedancing changed the base branch from develop to master April 18, 2023 08:31
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (bcab486) 49.51% compared to head (c837518) 49.53%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   49.51%   49.53%   +0.01%     
==========================================
  Files         126      126              
  Lines       12557    12557              
==========================================
+ Hits         6218     6220       +2     
+ Misses       5921     5918       -3     
- Partials      418      419       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants