0.7.2 Upgrade #756
Merged
0.7.2 Upgrade #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete recent price from db when delisting
yutianwu
previously approved these changes
Jun 24, 2020
#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height
rickyyangz
previously approved these changes
Jul 1, 2020
* fix unfreeze err msg; adjust mini issue/list fee; update changelog
rickyyangz
approved these changes
Jul 1, 2020
ackratos
reviewed
Jul 1, 2020
| @@ -73,7 +73,7 @@ func handleUnfreezeToken(ctx sdk.Context, tokenMapper store.Mapper, accKeeper au | |||
| if common.IsMiniTokenSymbol(symbol) { | |||
| if unfreezeAmount < common.MiniTokenMinExecutionAmount && frozenAmount != unfreezeAmount { | |||
| logger.Info("unfreeze token failed", "reason", "unfreeze amount doesn't reach the min amount") | |||
| return sdk.ErrInvalidCoins(fmt.Sprintf("freeze amount is too small, the min amount is %d or total frozen balance", | |||
| return sdk.ErrInvalidCoins(fmt.Sprintf("unfreeze amount is too small, the min amount is %d or total frozen balance", | |||
There was a problem hiding this comment.
would this cause consensus error? This should be part of ABCIResult?
There was a problem hiding this comment.
New feature on mainnet. We don't guarantee compatibility with testnet this time
ackratos
approved these changes
Jul 1, 2020
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* delete recent price from db when delisting (#753) delete recent price from db when delisting * bump up version * update changelog * delete recent price key when recent price map is empty (#760) * Force match all BEP2 symbols on BEP8 upgrade height to update last ma… (#758) Force match all BEP2 symbols on BEP8 upgrade height to update last match height * Fix mini msg (#762) * fix unfreeze err msg; adjust mini issue/list fee; update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BUG FIXES
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
#214 Wrong Block.Header.AppHash for 0.7.0 testnet