[R4R] node repo fix for state sync snapshot command #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackratos
changed the title
HaoyangLiu
reviewed
Jun 19, 2019
app/config/config.go
Outdated
| upgrade.Mgr.AddUpgradeHeight(upgrade.BEP6, upgradeConfig.BEP6Height) | ||
| upgrade.Mgr.AddUpgradeHeight(upgrade.BEP9, upgradeConfig.BEP9Height) | ||
| upgrade.Mgr.AddUpgradeHeight(upgrade.BEP10, upgradeConfig.BEP10Height) | ||
| upgrade.Mgr.AddUpgradeHeight(upgrade.BEP19, upgradeConfig.BEP10Height) |
There was a problem hiding this comment.
upgradeConfig.BEP10Height?
There was a problem hiding this comment.
upgradeConfig.BEP10Height?
@rickyyangz will have a PR fix this I think
yutianwu
approved these changes
Jun 19, 2019
HaoyangLiu
approved these changes
Jun 19, 2019
ackratos
force-pushed
the
statesync_upgrade
branch
from
fdb0e3e to
ca7d0ee
Compare
rickyyangz
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
node repo fix for bnb-chain/bnc-cosmos-sdk#150
Rationale
move set upgrade to upgrade config's method so that utility tools can override upgrade config
Example
N/A
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...