fix: add GlobalVirtualGroupFamilyId to createBucketPackage
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosinlink
approved these changes
Oct 16, 2023
unclezoro
reviewed
Oct 17, 2023
| @@ -425,8 +430,9 @@ func (p CreateBucketSynPackage) GetApprovalBytes() []byte { | |||
| PaymentAddress: p.PaymentAddress.String(), | |||
| PrimarySpAddress: p.PrimarySpAddress.String(), | |||
| PrimarySpApproval: &gnfdcommon.Approval{ | |||
| ExpiredHeight: p.PrimarySpApprovalExpiredHeight, | |||
| Sig: p.PrimarySpApprovalSignature, | |||
| ExpiredHeight: p.PrimarySpApprovalExpiredHeight, | |||
There was a problem hiding this comment.
Because you did not make it as a hard fork, it requires us that to disable the Bucket cross chain channels before the hardfork, and after the hardfork, we upgrade the smart contract , then enable the bucket channel.
unclezoro
approved these changes
Oct 17, 2023
This was referenced Nov 2, 2023
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to add missing property
GlobalVirtualGroupFamilyIdtocreateBucketPackageChanges
Notable changes:
GlobalVirtualGroupFamilyIdtocreateBucketPackagePotential Impacts
The steps for the next upgrade should be: