feat: add RemoveExpiredPolicies
#411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j75689
reviewed
Aug 9, 2023
pythonberg1997
force-pushed
the
develop
branch
from
d4603ba to
dc961ce
Compare
unclezoro
reviewed
Aug 10, 2023
| (gogoproto.stdtime) = true, | ||
| (gogoproto.nullable) = false | ||
| ]; | ||
| google.protobuf.Timestamp expiration_time = 2 [(gogoproto.stdtime) = true]; |
There was a problem hiding this comment.
So the expiration can be nil (means no expiration)
There was a problem hiding this comment.
do this change still needed? if Change this, off-chain service should adapt to this, nil == expiration
@pythonberg1997 @guagualvcha
There was a problem hiding this comment.
or we can set nil to maxTimestamp when getting members from rpc, producing events
unclezoro
reviewed
Aug 10, 2023
unclezoro
reviewed
Aug 10, 2023
unclezoro
reviewed
Aug 10, 2023
unclezoro
reviewed
Aug 10, 2023
unclezoro
reviewed
Aug 10, 2023
unclezoro
reviewed
Aug 10, 2023
unclezoro
reviewed
Aug 10, 2023
unclezoro
reviewed
Aug 10, 2023
pythonberg1997
force-pushed
the
develop
branch
from
9ec5293 to
0dc9fa1
Compare
pythonberg1997
changed the title
RemoveExpiredMembers and RemoveExpiredPoliciesRemoveExpiredPolicies
pythonberg1997
force-pushed
the
develop
branch
from
0dc9fa1 to
019c81f
Compare
unclezoro
reviewed
Aug 14, 2023
unclezoro
reviewed
Aug 14, 2023
unclezoro
approved these changes
Aug 14, 2023
pythonberg1997
force-pushed
the
develop
branch
from
d6346d5 to
eccbb85
Compare
pythonberg1997
force-pushed
the
develop
branch
from
3eb9c8f to
ff3406d
Compare
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to add method to remove expired data from the kv store
Rationale
To reduce the chain data
Changes
Notable changes:
GroupMemberexpiration can be nil nowRemoveExpiredPolicies