feat: custom upgrade module #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j75689
force-pushed
the
upgrade_module
branch
2 times, most recently
from
716fa02 to
ccef85b
Compare
unclezoro
reviewed
Jan 4, 2023
app/app.go
Outdated
| authtypes.NewModuleAddress(govtypes.ModuleName).String(), | ||
| ) | ||
| // Register the upgrade keeper | ||
| upgradeHandler := map[string]upgradetypes.UpgradeHandler{ |
There was a problem hiding this comment.
This is not a suitable place to define the detailed handler.
unclezoro
approved these changes
Jan 6, 2023
This was referenced Jan 6, 2023
j75689
added a commit
that referenced
this pull request
Jan 6, 2023
* disable unnecessary modules (#14) * feat: pass config to app when creating new app (#16) * feat: pass config to app when create new app * remove unused code * deployment: fix relayer key generation (#19) * feat: init balance of relayers in genesis state (#21) * ci: fix release flow (#20) * feat: custom upgrade module (#17) * release: prepare for v0.0.2 (#22) Co-authored-by: KeefeL <[email protected]> Co-authored-by: yutianwu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customize the upgrade module for BNB Inscription, and delete useless APIs from the original module.
Rationale
refer to: bnb-chain/greenfield-cosmos-sdk#82
Example
refer to: bnb-chain/greenfield-cosmos-sdk#82
Changes
Notable changes: