-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gashub module #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonberg1997
force-pushed
the
feehub
branch
from
December 22, 2022 06:44
ebce19e
to
a36a21e
Compare
pythonberg1997
force-pushed
the
feehub
branch
from
December 22, 2022 06:51
a36a21e
to
8d819e3
Compare
unclezoro
reviewed
Dec 22, 2022
unclezoro
reviewed
Dec 22, 2022
unclezoro
reviewed
Dec 22, 2022
unclezoro
reviewed
Dec 22, 2022
unclezoro
reviewed
Dec 22, 2022
unclezoro
reviewed
Dec 22, 2022
unclezoro
reviewed
Dec 22, 2022
unclezoro
reviewed
Dec 22, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Dec 26, 2022
unclezoro
reviewed
Jan 3, 2023
unclezoro
reviewed
Jan 3, 2023
unclezoro
reviewed
Jan 3, 2023
unclezoro
reviewed
Jan 3, 2023
unclezoro
reviewed
Jan 3, 2023
unclezoro
reviewed
Jan 5, 2023
unclezoro
reviewed
Jan 5, 2023
unclezoro
reviewed
Jan 5, 2023
unclezoro
reviewed
Jan 5, 2023
please refine the description of the PR. |
unclezoro
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new gashub module to manage the msg gas fee.
Now there's a relatively definite gas for every different msg type, which is determined by the msg gas params and the corresponding gas calculator.
For the developer, if a new msg type is added, the corresponding gas params and calculator for that msg type should be added to the gashub module accordingly.
Rationale
Transaction's gas consumption can be relatively definite under gashub.
Example
cosmos/gashub/v1alpha1/gashub.proto
x/gashub/types/params.go
Changes