fix: errors with EIP712 signature #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keefel
reviewed
Dec 19, 2022
| fieldType = reflect.TypeOf(anyWrapper.Value) | ||
| field = reflect.ValueOf(anyWrapper.Value) | ||
|
|
||
| // then continue as normal |
There was a problem hiding this comment.
Suggest add comments above if condition to explain how we deal with type any, no this comment.
There was a problem hiding this comment.
Yes, more comments for others to understand this part.
unclezoro
reviewed
Dec 19, 2022
| @@ -323,17 +323,27 @@ func traverseFields( | |||
| fieldType := t.Field(i).Type | |||
| fieldName := jsonNameFromTag(t.Field(i).Tag) | |||
|
|
|||
| if fieldName == "" { | |||
There was a problem hiding this comment.
Add some comments here as well, thanks.
There was a problem hiding this comment.
Find and summary the current structure that do not have fieldName .
unclezoro
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there are
types.Anyin the msg, some errors will happened with EIP712 signature.Rationale
N/A
Example
N/A
Changes
Add additional operations for
types.Any