feat: add validation with context information #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
commented
Sep 18, 2023
forcodedancing
force-pushed
the
runtime_validation
branch
from
546708e to
066a81a
Compare
yutianwu
approved these changes
Oct 17, 2023
j75689
approved these changes
Oct 17, 2023
unclezoro
reviewed
Oct 18, 2023
| @@ -43,6 +43,12 @@ func (k Keeper) SubmitProposal(ctx sdk.Context, messages []sdk.Msg, metadata, ti | |||
| return v1.Proposal{}, sdkerrors.Wrap(types.ErrInvalidProposalMsg, err.Error()) | |||
| } | |||
|
|
|||
| if runtimeMsg, ok := msg.(sdk.MsgWithRuntimeValidation); ok { | |||
There was a problem hiding this comment.
should this a hardfork?
unclezoro
approved these changes
Oct 18, 2023
This was referenced Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some validations are needed for different hardforks.
ValidateBasicdoes not have information to detect hardforks.ValidateRuntimecan be used for validations with hardfork information.Rationale
New feature
Example
NA
Changes
Notable changes:
ValidateRuntimefunction