Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track store r/w consume for enabling plain store #269

Merged
merged 8 commits into from
Aug 16, 2023
Merged

feat: track store r/w consume for enabling plain store #269

merged 8 commits into from
Aug 16, 2023

Conversation

forcodedancing
Copy link
Collaborator

@forcodedancing forcodedancing commented Aug 11, 2023 •
edited
Loading

Description

This pr will track store r/w consume into deliver tx result.

Rationale

For enabling plain store without IAVL, we need to enhance the LastResultHash when validating blocks.

Example

new flag EnablePlainStore = true

Changes

Notable changes:

  • new flag

@forcodedancing forcodedancing changed the title feat: track store r/w consume for enabling plain store [WIP] feat: track store r/w consume for enabling plain store Aug 11, 2023
@unclezoro unclezoro changed the title [WIP] feat: track store r/w consume for enabling plain store feat: track store r/w consume for enabling plain store Aug 14, 2023
unclezoro
unclezoro reviewed Aug 14, 2023
View reviewed changes
baseapp/abci.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Aug 14, 2023
View reviewed changes
baseapp/baseapp.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Aug 14, 2023
View reviewed changes
baseapp/baseapp.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Aug 14, 2023
View reviewed changes
types/context.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Aug 14, 2023
View reviewed changes
types/context.go Outdated Show resolved Hide resolved
unclezoro
unclezoro requested changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@unclezoro unclezoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need add more gasrw for endblock and begin block.

@forcodedancing forcodedancing force-pushed the feat/fn branch 2 times, most recently from c344a79 to 7240d3f Compare August 14, 2023 13:02
@unclezoro unclezoro added this pull request to the merge queue Aug 16, 2023
Merged via the queue into develop with commit db13145 Aug 16, 2023
@unclezoro unclezoro deleted the feat/fn branch August 16, 2023 01:59
This was referenced Aug 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
C:Store C:x/capability C:x/distribution C:x/gov C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forcodedancing @unclezoro