feat: add flag to enable or disable heavy queries #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Aug 1, 2023
server/start.go
Outdated
| @@ -186,6 +188,7 @@ is performed. Note, when enabled, gRPC will also be automatically enabled. | |||
| cmd.Flags().Uint(FlagInvCheckPeriod, 0, "Assert registered invariants every N blocks") | |||
| cmd.Flags().Uint64(FlagMinRetainBlocks, 0, "Minimum block height offset during ABCI commit to prune Tendermint blocks") | |||
| cmd.Flags().String(FlagEventing, sdk.EventingOptionEverything, "Eventing strategy (everything|nothing)") | |||
| cmd.Flags().Bool(FlagEnableUnsafeQuery, true, "Define if unsafe query should be enabled (unsafe - use it at your own risk)") | |||
There was a problem hiding this comment.
The default value should be false, user need to set it to true only they know what exact it means.
unclezoro
previously approved these changes
Aug 1, 2023
|
Wired, the latest commit does not display here. |
After changing base branch, it shows. |
unclezoro
approved these changes
Aug 3, 2023
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will add a flag
enable-unsafe-queryto enable/disable heavy or unsafe queries.Rationale
Some queries are very heavy, we should have a flag to enable or disable such queries.
Example
Changes
Notable changes: