Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the security issues #219

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix: fix the security issues #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x/oracle/keeper/msg_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ func (k Keeper) distributeReward(ctx sdk.Context, relayer sdk.AccAddress, signed
if err != nil {
return err
}
} else if remainingReward.IsNegative() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the title, let us not use fix security issue, but talk about the detailed problem.

panic("remaining reward should not be negative")
}

return nil
Expand Down