Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix blockchain stop to produce blocks #211

Merged
merged 3 commits into from
May 26, 2023

Conversation

forcodedancing
Copy link
Collaborator

@forcodedancing forcodedancing commented May 24, 2023

Description

Fix blocking issue.

Rationale

https://github.com/cometbft/cometbft/blob/main/spec/abci/abci%2B%2B_basic_concepts.md

[ProcessProposal:](https://github.com/cometbft/cometbft/blob/main/spec/abci/abci++_methods.md#processproposal) It allows a validator to perform application-dependent work in a proposed block. This enables features such as immediate block execution, and allows the Application to reject invalid blocks.

CometBFT calls it when it receives a proposal and validValue is nil. The Application cannot modify the proposal at this point but can reject it if it is invalid. If that is the case, the consensus algorithm will prevote nil on the proposal, which has strong liveness implications for CometBFT. As a general rule, the Application SHOULD accept a prepared proposal passed via ProcessProposal, even if a part of the proposal is invalid (e.g., an invalid transaction); the Application can ignore the invalid part of the prepared proposal at block execution time.

Example

NA (keep un disclosured)

Changes

Notable changes:

  • NA

release: prepare for release v0.2.1-alpha.1
baseapp/baseapp.go Outdated Show resolved Hide resolved
baseapp/baseapp.go Outdated Show resolved Hide resolved
@unclezoro unclezoro changed the base branch from master to develop May 26, 2023 02:08
@unclezoro unclezoro merged commit 15cab38 into bnb-chain:develop May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants