Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple messages for EIP712 #205

Merged
merged 4 commits into from
May 22, 2023
Merged

feat: support multiple messages for EIP712 #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f32f44
feat: support multiple messages for EIP712
forcodedancing May 16, 2023
d6ce237
fix: update `GetMsgTypes` and `cleanTypesAndMsgValue` functions
pythonberg1997 May 16, 2023
44edc9a
fix review comments
forcodedancing May 19, 2023
8843df3
add type info to msg
forcodedancing May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
386 changes: 222 additions & 164 deletions api/cosmos/tx/v1beta1/tx.pulsar.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion client/tx/factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type Factory struct {
func NewFactoryCLI(clientCtx client.Context, flagSet *pflag.FlagSet) (Factory, error) {
signModeStr := clientCtx.SignModeStr

signMode := signing.SignMode_SIGN_MODE_UNSPECIFIED
signMode := signing.SignMode_SIGN_MODE_EIP_712
switch signModeStr {
case flags.SignModeDirect:
signMode = signing.SignMode_SIGN_MODE_DIRECT
Expand Down
5 changes: 2 additions & 3 deletions proto/cosmos/tx/v1beta1/tx.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,7 @@ message SignDocDirectAux {
Tip tip = 6;
}

// SignDocEIP712 is the type used for generating sign bytes for
// SIGN_MODE_EIP_712.
// SignDocEIP712 is the type used for generating sign bytes for SIGN_MODE_EIP_712.
message SignDocEip712 {
// chain_id is the identifier of the chain this transaction targets.
// It prevents signed transactions from being used on another chain by an
Expand All @@ -117,7 +116,7 @@ message SignDocEip712 {
Fee fee = 4 [(gogoproto.nullable) = false];

// msg is the msg in the EIP712 transaction.
google.protobuf.Any msg = 5;
repeated google.protobuf.Any msgs = 5;

// timeout_height is the transaction's timeout height (if set).
uint64 timeout_height = 6 [(gogoproto.jsontag) = "timeout_height"];
Expand Down
189 changes: 95 additions & 94 deletions types/tx/tx.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading