feat: split commands for withdraw rewards and commission due to eip712 #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@forcodedancing your pull request is missing a changelog! |
forcodedancing
commented
Apr 13, 2023
| @@ -184,7 +184,7 @@ func SimulateMsgWithdrawValidatorCommission(txConfig client.TxConfig, ak types.A | |||
| account := ak.GetAccount(ctx, simAccount.Address) | |||
| spendable := bk.SpendableCoins(ctx, account.GetAddress()) | |||
|
|
|||
| msg := types.NewMsgWithdrawValidatorCommission(validator.GetOperator()) | |||
| msg := types.NewMsgWithdrawValidatorCommission(sdk.AccAddress(validator.GetOperator())) | |||
There was a problem hiding this comment.
Currently, in staking module validator's operator is using ValAddress type. Need to change in the following prs.
There was a problem hiding this comment.
right, I have found some places in other modules too
unclezoro
approved these changes
Apr 13, 2023
unclezoro
approved these changes
Apr 13, 2023
yutianwu
pushed a commit
to yutianwu/greenfield-cosmos-sdk
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr migrates the change of:
#108 feat: split commands for withdrawal of rewards and commission
Rationale
Due to the EIP712 requirement, only one message can be executed in an single transaction.
Example
withdraw-rewardswithdraw-commissionChanges
Notable changes: