fix: keep address format the same with ethereum #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
reviewed
Mar 7, 2023
types/address.go
Outdated
| @@ -493,7 +494,10 @@ func (ca ConsAddress) Equals(ca2 Address) bool { | |||
|
|
|||
| // Returns boolean for whether an ConsAddress is empty | |||
| func (ca ConsAddress) Empty() bool { | |||
| return len(ca) == 0 | |||
| addrValue := big.NewInt(0) | |||
There was a problem hiding this comment.
if we change to this, then 0x0000000000000000000000000000000000000000 is empty, is this expected
yutianwu
approved these changes
Mar 8, 2023
unclezoro
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the same decode method with Ethereum address, so that we can handle the address case correctly.
Rationale
The previous decode method of address can't handle the case insensitive issues, the address in uppercase and lowercase would be regarded as two different addresses, which is not as expected.
Example
NA
Changes
Notable changes: