Skip to content

Commit

Permalink
fix bugs
Browse files Browse the repository at this point in the history
  • Loading branch information
Keefe Liu committed Feb 15, 2023
1 parent 84c5fbf commit d44ae71
Show file tree
Hide file tree
Showing 5 changed files with 290 additions and 226 deletions.
11 changes: 7 additions & 4 deletions x/slashing/client/testutil/cli_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,27 @@ import (
"testing"
"time"

"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"

"github.com/cosmos/cosmos-sdk/testutil/network"
sdk "github.com/cosmos/cosmos-sdk/types"
v1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
)

func TestIntegrationTestSuite(t *testing.T) {
cfg := network.DefaultConfig()
cfg.NumValidators = 3
cfg.NumValidators = 1
suite.Run(t, NewIntegrationTestSuite(cfg))

dp := v1.NewDepositParams(sdk.NewCoins(sdk.NewCoin(cfg.BondDenom, v1.DefaultMinDepositTokens)), time.Duration(15)*time.Second)
vp := v1.NewVotingParams(time.Duration(10) * time.Second)
vp := v1.NewVotingParams(time.Duration(5) * time.Second)
genesisState := v1.DefaultGenesisState()
genesisState.DepositParams = &dp
genesisState.VotingParams = &vp
bz, err := cfg.Codec.MarshalJSON(genesisState)
require.NoError(t, err)
cfg.GenesisState["gov"] = bz
cfg.NumValidators = 3
suite.Run(t, NewImpeachValidatorTestSuite(cfg))
}
189 changes: 100 additions & 89 deletions x/slashing/client/testutil/impeach_validator.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,45 @@ import (
"encoding/base64"
"fmt"
"os"
"strings"
"time"

"github.com/stretchr/testify/suite"
tmcli "github.com/tendermint/tendermint/libs/cli"

"github.com/cosmos/cosmos-sdk/client/flags"
"github.com/cosmos/cosmos-sdk/testutil"
clitestutil "github.com/cosmos/cosmos-sdk/testutil/cli"
"github.com/cosmos/cosmos-sdk/testutil/network"
sdk "github.com/cosmos/cosmos-sdk/types"
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
govcli "github.com/cosmos/cosmos-sdk/x/gov/client/cli"
gov "github.com/cosmos/cosmos-sdk/x/gov/types"
v1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
"github.com/cosmos/cosmos-sdk/x/staking/client/cli"
stakingtestutil "github.com/cosmos/cosmos-sdk/x/staking/client/testutil"
"github.com/cosmos/cosmos-sdk/x/staking/types"
"github.com/stretchr/testify/suite"
tmcli "github.com/tendermint/tendermint/libs/cli"
)

type testParams struct {
discription string
proposalID string
from string
}

var testcases = []testParams{
{
discription: "impeach the last validator",
proposalID: "1",
from: "0x7b5Fe22B5446f7C62Ea27B8BD71CeF94e03f3dF2",
},
{
discription: "impeach the last validator again",
proposalID: "2",
from: "0x7b5Fe22B5446f7C62Ea27B8BD71CeF94e03f3dF2",
},
{
discription: "impeach the last validator, but invalid from",
proposalID: "3",
from: "0x8b70dC9B691fCeB4e1c69dF8cbF8c077AD4b5853",
},
}

type ImpeachValidatorTestSuite struct {
suite.Suite

Expand All @@ -45,29 +65,11 @@ func (s *ImpeachValidatorTestSuite) SetupSuite() {
_, err = s.network.WaitForHeight(1)
s.Require().NoError(err)

// Invalid proposal (--from address not gov)
s.submitProposal(s.network.Validators[0].ValAddress.String(), false)

// Valid proposal
s.submitProposal(gov.ModuleName, true)
proposalID := fmt.Sprintf("%d", 1)
s.proposalIDs = append(s.proposalIDs, proposalID)

// Valid proposal to impeach the same validator that was already impeached
s.submitProposal(gov.ModuleName, true)
proposalIDInvalidImpeached := fmt.Sprintf("%d", 2)
s.proposalIDs = append(s.proposalIDs, proposalIDInvalidImpeached)

for _, proposal := range s.proposalIDs {
s.voteProposal(proposal, s.network.Validators[0], "yes")
s.voteProposal(proposal, s.network.Validators[1], "yes")
s.voteProposal(proposal, s.network.Validators[2], "no")
for _, testcase := range testcases {
s.submitProposal(testcase)
s.voteProposal(testcase.proposalID)
s.proposalIDs = append(s.proposalIDs, testcase.proposalID)
}

time.Sleep(10 * time.Second)

s.TestQuerySuccessfulImpeachedValidator()
s.TestQueryInvalidAlreadyImpeached()
}

func (s *ImpeachValidatorTestSuite) SetupNewSuite() {
Expand All @@ -81,59 +83,15 @@ func (s *ImpeachValidatorTestSuite) SetupNewSuite() {
s.Require().NoError(err)
}

func (s *ImpeachValidatorTestSuite) submitProposal(from string, isValidTestCase bool) {
val := s.network.Validators[0]
clientCtx := val.ClientCtx

kickedVal := s.network.Validators[2]

args := append([]string{
s.ImpeachValidatorProposal(kickedVal.Address, from).Name(),
fmt.Sprintf("--%s=%s", flags.FlagFrom, val.ValAddress.String()),
fmt.Sprintf("--gas=%s", fmt.Sprintf("%d", flags.DefaultGasLimit+100000)),
}, stakingtestutil.CommonArgs...)

response, err := clitestutil.ExecTestCLICmd(clientCtx, govcli.NewCmdSubmitProposal(), args)

if err == nil {
splits := strings.Split(response.String(), ",")
splits = strings.Split(splits[2], ":")
codespace := strings.Trim(splits[1], "\"")
if string(codespace) != "" {
err = gov.ErrInvalidProposalMsg
}
}

if isValidTestCase {
s.Require().NoError(err)
} else {
s.Require().Error(err)
}
}

func (s *ImpeachValidatorTestSuite) voteProposal(proposalID string, val *network.Validator, voteOption string) {
clientCtx := val.ClientCtx
clientCtx.Client = s.network.Validators[0].RPCClient

args := append([]string{
proposalID,
voteOption,
fmt.Sprintf("--%s=%s", flags.FlagFrom, val.Address.String()),
}, stakingtestutil.CommonArgs...)
_, err := clitestutil.ExecTestCLICmd(clientCtx, govcli.NewCmdVote(), args)
s.Require().NoError(err)
}

func (s *ImpeachValidatorTestSuite) TearDownSuite() {
s.T().Log("tearing down test suite")
s.network.Cleanup()
}

func (s *ImpeachValidatorTestSuite) TestQuerySuccessfulImpeachedValidator() {
val := s.network.Validators[0]
clientCtx := val.ClientCtx
proposalID := s.proposalIDs[0]
kickedVal := s.network.Validators[2]
targetVal := s.network.Validators[len(s.network.Validators)-1]
clientCtx := s.network.Validators[0].ClientCtx

// query proposal
args := []string{proposalID, fmt.Sprintf("--%s=json", tmcli.OutputFlag)}
Expand All @@ -146,21 +104,20 @@ func (s *ImpeachValidatorTestSuite) TestQuerySuccessfulImpeachedValidator() {
// query validator
queryCmd := cli.GetCmdQueryValidator()
res, err := clitestutil.ExecTestCLICmd(
val.ClientCtx, queryCmd,
[]string{kickedVal.Address.String(), fmt.Sprintf("--%s=json", tmcli.OutputFlag)},
clientCtx, queryCmd,
[]string{targetVal.Address.String(), fmt.Sprintf("--%s=json", tmcli.OutputFlag)},
)
s.Require().NoError(err)
var result types.Validator
s.Require().NoError(val.ClientCtx.Codec.UnmarshalJSON(res.Bytes(), &result))
s.Require().NotEqual(result.GetStatus(), types.Bonded, fmt.Sprintf("validator %s not in bonded status", kickedVal.Address.String()))
s.Require().NoError(clientCtx.Codec.UnmarshalJSON(res.Bytes(), &result))
s.Require().NotEqual(result.GetStatus(), types.Bonded, fmt.Sprintf("validator %s not in bonded status", targetVal.Address.String()))
s.Require().Equal(result.Jailed, true)
}

func (s *ImpeachValidatorTestSuite) TestQueryInvalidAlreadyImpeached() {
val := s.network.Validators[0]
clientCtx := val.ClientCtx
func (s *ImpeachValidatorTestSuite) TestQueryDoubleImpeachedValidator() {
proposalID := s.proposalIDs[1]
kickedVal := s.network.Validators[2]
targetVal := s.network.Validators[len(s.network.Validators)-1]
clientCtx := s.network.Validators[0].ClientCtx

// query proposal
args := []string{proposalID, fmt.Sprintf("--%s=json", tmcli.OutputFlag)}
Expand All @@ -173,17 +130,46 @@ func (s *ImpeachValidatorTestSuite) TestQueryInvalidAlreadyImpeached() {
// query validator
queryCmd := cli.GetCmdQueryValidator()
res, err := clitestutil.ExecTestCLICmd(
val.ClientCtx, queryCmd,
[]string{kickedVal.Address.String(), fmt.Sprintf("--%s=json", tmcli.OutputFlag)},
clientCtx, queryCmd,
[]string{targetVal.Address.String(), fmt.Sprintf("--%s=json", tmcli.OutputFlag)},
)
s.Require().NoError(err)
var result types.Validator
s.Require().NoError(val.ClientCtx.Codec.UnmarshalJSON(res.Bytes(), &result))
s.Require().NotEqual(result.GetStatus(), types.Bonded, fmt.Sprintf("validator %s not in bonded status", kickedVal.Address.String()))
s.Require().NoError(clientCtx.Codec.UnmarshalJSON(res.Bytes(), &result))
s.Require().NotEqual(result.GetStatus(), types.Bonded, fmt.Sprintf("validator %s not in bonded status", targetVal.Address.String()))
s.Require().Equal(result.Jailed, true)
}

func (s *ImpeachValidatorTestSuite) ImpeachValidatorProposal(valAddr sdk.AccAddress, from string) *os.File {
func (s *ImpeachValidatorTestSuite) TestQueryInvalidFromAddress() {
proposalID := s.proposalIDs[2]
clientCtx := s.network.Validators[0].ClientCtx

// query proposal, should not be found because of invalid from the proposal will be rejected.
args := []string{proposalID, fmt.Sprintf("--%s=json", tmcli.OutputFlag)}
_, err := clitestutil.ExecTestCLICmd(clientCtx, govcli.GetCmdQueryProposal(), args)
s.Require().Error(err)
}

func (s *ImpeachValidatorTestSuite) submitProposal(params testParams) {
val := s.network.Validators[0]
clientCtx := val.ClientCtx

// Always impeach the last validator.
targetVal := s.network.Validators[len(s.network.Validators)-1]
args := []string{
s.impeachValidatorProposal(targetVal.Address, params.from).Name(),
fmt.Sprintf("--%s=%s", flags.FlagFrom, val.ValAddress.String()),
fmt.Sprintf("--gas=%s", fmt.Sprintf("%d", flags.DefaultGasLimit+100000)),
fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastBlock),
fmt.Sprintf("--%s=%s", flags.FlagFees, sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(10))).String()),
}

_, err := clitestutil.ExecTestCLICmd(clientCtx, govcli.NewCmdSubmitProposal(), args)
s.Require().NoError(err)
}

func (s *ImpeachValidatorTestSuite) impeachValidatorProposal(valAddr sdk.AccAddress, from string) *os.File {
propMetadata := []byte{42}
proposal := fmt.Sprintf(`
{
Expand All @@ -197,7 +183,7 @@ func (s *ImpeachValidatorTestSuite) ImpeachValidatorProposal(valAddr sdk.AccAddr
"metadata": "%s",
"deposit": "%s"
}`,
authtypes.NewModuleAddress(from),
from,
valAddr.String(),
base64.StdEncoding.EncodeToString(propMetadata),
sdk.NewCoin(s.cfg.BondDenom, v1.DefaultMinDepositTokens),
Expand All @@ -206,3 +192,28 @@ func (s *ImpeachValidatorTestSuite) ImpeachValidatorProposal(valAddr sdk.AccAddr
proposalFile := testutil.WriteToNewTempFile(s.T(), proposal)
return proposalFile
}

func (s *ImpeachValidatorTestSuite) voteProposal(proposalID string) {
for i := 0; i < len(s.network.Validators); i++ {
clientCtx := s.network.Validators[i].ClientCtx
clientCtx.Client = s.network.Validators[0].RPCClient

// The last validator vote no, others vote yes.
voteOption := "yes"
if i == len(s.network.Validators)-1 {
voteOption = "no"
}

args := []string{
proposalID,
voteOption,
fmt.Sprintf("--%s=%s", flags.FlagFrom, s.network.Validators[i].Address.String()),
fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastBlock),
fmt.Sprintf("--%s=%s", flags.FlagFees, sdk.NewCoins(sdk.NewCoin(sdk.DefaultBondDenom, sdk.NewInt(10))).String()),
}

_, err := clitestutil.ExecTestCLICmd(clientCtx, govcli.NewCmdVote(), args)
s.Require().NoError(err)
}
}
7 changes: 5 additions & 2 deletions x/staking/client/testutil/cli_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,18 @@ import (
"testing"
"time"

"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"

"github.com/cosmos/cosmos-sdk/testutil/network"
sdk "github.com/cosmos/cosmos-sdk/types"
v1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
"github.com/stretchr/testify/require"
"github.com/stretchr/testify/suite"
)

func TestIntegrationTestSuite(t *testing.T) {
cfg := network.DefaultConfig()
cfg.NumValidators = 2
suite.Run(t, NewIntegrationTestSuite(cfg))

dp := v1.NewDepositParams(sdk.NewCoins(sdk.NewCoin(cfg.BondDenom, v1.DefaultMinDepositTokens)), time.Duration(15)*time.Second)
vp := v1.NewVotingParams(time.Duration(5) * time.Second)
Expand All @@ -26,5 +28,6 @@ func TestIntegrationTestSuite(t *testing.T) {
bz, err := cfg.Codec.MarshalJSON(genesisState)
require.NoError(t, err)
cfg.GenesisState["gov"] = bz
cfg.NumValidators = 2
suite.Run(t, NewCreateValidatorTestSuite(cfg))
}
Loading

0 comments on commit d44ae71

Please sign in to comment.