Merge pull request #338 from forcodedancing/disable_total_for_empty_r…

…equest

fix: do not count total when pagination request is empty

types/query/pagination.go

@@ -81,9 +81,8 @@ func Paginate(
 
 	if limit == 0 {
 		limit = DefaultLimit
-
-		// count total results when the limit is zero/not supplied
-		countTotal = true
+		// do not count total results when the limit is zero/not supplied
+		// countTotal = true
 	} else if limit > DefaultLimit {
 		// limit to protect the node would not be Query DoS
 		limit = DefaultLimit

types/query/pagination_test.go

@@ -122,7 +122,8 @@ func (s *paginationTestSuite) TestPagination() {
 	request := types.NewQueryAllBalancesRequest(addr1, pageReq)
 	res, err := queryClient.AllBalances(gocontext.Background(), request)
 	s.Require().NoError(err)
-	s.Require().Equal(res.Pagination.Total, uint64(numBalances))
+	// default page request will not return total count
+	// s.Require().Equal(res.Pagination.Total, uint64(numBalances))
 	s.Require().NotNil(res.Pagination.NextKey)
 	s.Require().LessOrEqual(res.Balances.Len(), defaultLimit)