feat: add GreenfieldExecutor
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Mar 19, 2024
unclezoro
reviewed
Mar 19, 2024
unclezoro
reviewed
Mar 19, 2024
unclezoro
reviewed
Mar 21, 2024
unclezoro
reviewed
Mar 21, 2024
unclezoro
reviewed
Mar 21, 2024
unclezoro
reviewed
Mar 21, 2024
unclezoro
reviewed
Mar 21, 2024
unclezoro
reviewed
Mar 21, 2024
unclezoro
approved these changes
Mar 23, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 7, 2024
… in a transaction (#140) * feat: add MultiMessage * feat: add MultiMessage and modify BucketHub * feat: add multi message handler in CrossChain * fix: lint * feat: add interface * feat: rename encodeCreateBucket to prepareBucket * feat: add prepare delete bucket * chores: lint code * feat: add sequence check for ack package from multi-message * fix: add relayer refund for ack packages split multi-message * chores: lint * fix: prepare for GroupHub * fix: add prepare function for update group * fix: add prepare delete group * fix: use sender instead of msg.sender * feat: modify handle ack package from multi message * fix: add interface in GroupHub * fix: add interface for BucketHub * fix: add channel id check and object interface * feat: support TokenHub to multi-message * feat: add `GreenfieldExecutor` (#141) * feat: add `GreenfieldExecutor` * update `execute` function * fix review comments * update supported messages * fix build error * update deploy script * fix review comments * fix typo * update hardhat config * add unit test * add annotation * feat: add multi-message support for permissionHub * fix: add channel id check before assign * fix: deploy check * fix: msg value check for multi message * fix: multi message contract issues, add interface and scripts * fix: add size limit for tokenHub transferOut from multi-message * fix: test * fix: limit transferOut amount to 0.1 BNB from multi-message * fix: add refund amount check from multi-message * fix: unit test * chores: lint code * feat: add events for multi message --------- Co-authored-by: Roshan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to add a new system contract
GreenfieldExecutorwhich is used to send greenfield msgs from BSC to greenfield.For more information, please refer to BEP363.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
GNFD_EXECUTOR_CHANNELand corresponding contractGreenfieldExecutor