feat: improve cmd of downloading and uploading #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flywukong
changed the title
flywukong
changed the title
* feat: support resumable download * feat: fix some comment
flywukong
force-pushed
the
improve-cmd
branch
from
83af1a5 to
9ced606
Compare
alexgao001
reviewed
Sep 18, 2023
|
|
||
| // Check if object is sealed | ||
| timeout := time.After(1 * time.Hour) |
There was a problem hiding this comment.
does it need to be that long?
There was a problem hiding this comment.
After our discussion, we changed the seal printing strategy here. Users can manually cancel the wait for seal or set --bypassSeal now. If they do not cancel, they will wait until seal by default, so this time can actually be infinite.
| } | ||
| return filePath, fmt.Errorf("download file:%s already exist\n", filePath) | ||
| } | ||
| return filePath, nil |
There was a problem hiding this comment.
return filePath, nil -> return filePath, err
There was a problem hiding this comment.
If this file does not exist, it will be created for the user using CREAT mode open, so there is no need to return err.
cmd/utils.go
Outdated
| @@ -103,6 +105,7 @@ const ( | |||
|
|
|||
| noBalanceErr = "key not found" | |||
| maxListMemberNum = 1000 | |||
| objectLargerSize = 10 * 1024 * 1024 | |||
There was a problem hiding this comment.
a little bit confused the naming
alexgao001
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rationale
improve cmd API
Example
Changes