feat: support resumable upload #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flywukong
reviewed
Jun 27, 2023
cmd/utils.go
Outdated
|
|
||
| // resumable download & upload | ||
| partSizeFlag = "partSize" | ||
| disableResumableFlag = "disable-resumable" |
There was a problem hiding this comment.
suggest to: change to MultipartFlag = "multipartUpload"
There was a problem hiding this comment.
We can change to support by default after the API tested stable
There was a problem hiding this comment.
default multipartUpload = false , not use resumble API
There was a problem hiding this comment.
- Fixed
disableResumableFlag = "disable-resumable"toresumableUploadFlag = "resumableUpload" - By default, the resumable upload feature is disabled, indicated by the value false.
leowkong
approved these changes
Jun 28, 2023
jingjunLi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.Support resumableUpload flag in put command
2. update dependency
Rationale
tell us why we need these changes...
Example
NA
Changes
Notable changes: