Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support parsing content type when uploading files #101

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

flywukong
Copy link
Collaborator

@flywukong flywukong commented Nov 20, 2023

Description

when uploading files, we can parse the mime type , and set the content type of the object as the mime type

Rationale

set the accurate content type

Example

upload a jpeg file , the content type has been set
image

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Copy link

@keefel keefel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flywukong flywukong merged commit 0b60d85 into bnb-chain:master Nov 20, 2023
5 checks passed
STdevK added a commit to STdevK/greenfield-docs that referenced this pull request Nov 29, 2023
new support feature from bnb-chain/greenfield-cmd#101, remove obsolete FAQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants